From: Brandon Casey <redacted>
We can avoid a GNU dependency by using /usr/ucb/install.
Signed-off-by: Brandon Casey <redacted>
---
This works for me on Solaris 7 and 10. Any reason not to use it instead
of ginstall?
-brandon
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
From: Brandon Casey <redacted>
This library is required on Solaris since hstrerror resides in libresolv.
Additionally, on Solaris 7, inet_ntop and inet_pton reside there too.
Signed-off-by: Brandon Casey <redacted>
---
Makefile | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
@@ -91,6 +91,10 @@ all::# Define NEEDS_SOCKET if linking with libc is not enough (SunOS,# Patrick Mauritz).#+# Define NEEDS_RESOLV if linking with -lnsl and/or -lsocket is not enough.+# Notably on Solaris hstrerror resides in libresolv and on Solaris 7+# inet_ntop and inet_pton additionally reside there.+## Define NO_MMAP if you want to avoid mmap.## Define NO_PTHREADS if you do not have or do not want to use Pthreads.
From: Junio C Hamano <redacted>
Some platforms (like SunOS and family) have kept their common binaries at
some historical moment in time, and introduced new binaries with modern
features in a special location like /usr/xpg4/bin or /usr/ucb. Some of the
features provided by these modern binaries are expected and required by git.
If the featureful binaries are not in the users path, then git could end up
using the less featureful binary and fail.
So provide a mechanism to prepend elements to the users PATH at runtime so
the modern binaries will be found.
Signed-off-by: Brandon Casey <redacted>
---
I liked this patch. Seems like the right thing to do on Solaris.
-brandon
Makefile | 14 ++++++++++++++
git-sh-setup.sh | 2 ++
2 files changed, 16 insertions(+), 0 deletions(-)
@@ -3,6 +3,11 @@ all::# Define V=1 to have a more verbose compile.#+# Define SHELL_PATH to a POSIX shell if your /bin/sh is broken.+#+# Define SANE_TOOL_PATH to a colon-separated list of paths to prepend+# to PATH if your tools in /usr/bin are broken.+## Define SNPRINTF_RETURNS_BOGUS if your are on a system which snprintf()# or vsnprintf() return -1 instead of number of characters which would# have been written to the final string if enough space had been available.
From: Jeff King <hidden> Date: 2016-06-15 22:46:52
On Wed, May 27, 2009 at 09:17:05PM -0500, Brandon Casey wrote:
We can avoid a GNU dependency by using /usr/ucb/install.
[...]
This works for me on Solaris 7 and 10. Any reason not to use it instead
of ginstall?
Certainly it works on Solaris 8; I've been setting it manually to
/usr/ucb/install (though I admit my auto-test script doesn't actually do
the install, I do occasionally run the install manually). I think it is
a sane default.
-Peff
From: Jeff King <hidden> Date: 2016-06-15 22:46:52
On Wed, May 27, 2009 at 09:17:06PM -0500, Brandon Casey wrote:
This library is required on Solaris since hstrerror resides in libresolv.
Additionally, on Solaris 7, inet_ntop and inet_pton reside there too.
Patch works for me on Solaris 8, though it is largely a non-issue:
hstrerror is only used at all if NO_IPV6 is set, and I don't set that
for my build.
-Peff
From: Jeff King <hidden> Date: 2016-06-15 22:46:52
On Wed, May 27, 2009 at 09:17:08PM -0500, Brandon Casey wrote:
Some platforms (like SunOS and family) have kept their common binaries at
some historical moment in time, and introduced new binaries with modern
features in a special location like /usr/xpg4/bin or /usr/ucb. Some of the
features provided by these modern binaries are expected and required by git.
If the featureful binaries are not in the users path, then git could end up
using the less featureful binary and fail.
So provide a mechanism to prepend elements to the users PATH at runtime so
the modern binaries will be found.
My concern with this is that the PATH bleeds over into things we execute
on behalf of the user, like GIT_EDITOR or snippets in git-filter-branch.
So we can end up surprising users that way.
On the other hand, I don't know how big a problem that is in practice. I
feel like any sane Solaris user is going to have xpg4 in their PATH
these days.
-Peff
From: Jeff King <hidden> Date: 2016-06-15 22:46:52
On Thu, May 28, 2009 at 02:32:20PM -0500, Brandon Casey wrote:
quoted
quoted
This library is required on Solaris since hstrerror resides in libresolv.
Additionally, on Solaris 7, inet_ntop and inet_pton reside there too.
Patch works for me on Solaris 8, though it is largely a non-issue:
hstrerror is only used at all if NO_IPV6 is set, and I don't set that
for my build.
Ah, in that case I guess NEED_RESOLV should only go in the 5.7 specific
configuration section.
Well, not exactly. Getting rid of NO_HSTRERROR and then compiling with
NO_IPV6 still requires NEED_RESOLV. It's just that NO_HSTRERROR isn't
even useful unless NO_IPV6 is defined.
-Peff