DORMANTno replies

[PATCH] Have make fail when $(DOCBOOK2X_TEXI) fails in building gitman.texi

From: Samuel Bronson <hidden>
Date: 2016-06-15 22:46:49
Subsystem: documentation, the rest · Maintainers: Jonathan Corbet, Linus Torvalds

This is handy for when docbook2x isn't installed. Without this change,
we would just build a mostly-empty gitman.texi rather than failing as we
should.

Signed-off-by: Samuel Bronson <redacted>
---
 Documentation/Makefile |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/Makefile b/Documentation/Makefile
index 144ec32..2998f0d 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -205,9 +205,11 @@ user-manual.pdf: user-manual.xml
 	mv $@+ $@
 
 gitman.texi: $(MAN_XML) cat-texi.perl
-	$(RM) $@+ $@
+	$(RM) $@++ $@+ $@
 	($(foreach xml,$(MAN_XML),$(DOCBOOK2X_TEXI) --encoding=UTF-8 \
-		--to-stdout $(xml);)) | $(PERL_PATH) cat-texi.perl $@ >$@+
+		--to-stdout $(xml);)) >$@++
+	$(PERL_PATH) cat-texi.perl $@ <$@++ >$@+
+	$(RM) $@++
 	mv $@+ $@
 
 gitman.info: gitman.texi
-- 
1.6.3.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help