DORMANTno replies

[PATCH 05/18] http-push: do not SEGV after fetching a bad pack idx file

From: Tay Ray Chuan <hidden>
Date: 2016-06-15 22:46:49
Subsystem: the rest · Maintainer: Linus Torvalds

In a70c232 ("http-fetch: do not SEGV after fetching a bad pack idx
file"), changes were made to the setup_index method in http-fetch.c
(known in its present form as http-walker.c after 30ae764 ("Modularize
commit-walker")). Since http-push.c has similar similar code for
processing index files, these changes should apply to http-push.c's
implementation of setup_index as well.

Signed-off-by: Tay Ray Chuan <redacted>
---
 http-push.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/http-push.c b/http-push.c
index 9655b2c..c48bb73 100644
--- a/http-push.c
+++ b/http-push.c
@@ -1061,6 +1061,8 @@ static int setup_index(unsigned char *sha1)
 		return -1;

 	new_pack = parse_pack_index(sha1);
+	if (!new_pack)
+		return -1; /* parse_pack_index() already issued error message */
 	new_pack->next = repo->packs;
 	repo->packs = new_pack;
 	return 0;
--
1.6.3.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help