[PATCH 0/5] A few minor MinGW changes

DORMANTno replies

6 messages, 1 author, 2016-06-15 · open the first message on its own page

[PATCH 0/5] A few minor MinGW changes

From: Steffen Prohaska <hidden>
Date: 2016-06-15 22:46:49

Here are a few simple commits that are included in the msysgit
release but not in git.git.

        Steffen

Johannes Schindelin (4):
  MinGW: the path separator to split GITPERLLIB is ';' on Win32
  MinGW: use POSIX signature of waitpid()
  MinGW: Add a simple getpass()
  MinGW: Fix compiler warning in merge-recursive

Peter Harris (1):
  MinGW: Scan for \r in addition to \n when reading shbang lines

 Makefile                  |    4 +++-
 builtin-merge-recursive.c |    5 +++--
 compat/mingw.c            |   19 +++++++++++++++++--
 compat/mingw.h            |    4 +++-
 4 files changed, 26 insertions(+), 6 deletions(-)

[PATCH 1/5] MinGW: Scan for \r in addition to \n when reading shbang lines

From: Steffen Prohaska <hidden>
Date: 2016-06-15 22:46:49

From: Peter Harris <redacted>

\r is common on Windows, so we should handle it gracefully.

Signed-off-by: Steffen Prohaska <redacted>
---
 compat/mingw.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/compat/mingw.c b/compat/mingw.c
index cdeda1d..b723c4d 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c

@@ -525,8 +525,8 @@ static const char *parse_interpreter(const char *cmd)
 	if (buf[0] != '#' || buf[1] != '!')
 		return NULL;
 	buf[n] = '\0';
-	p = strchr(buf, '\n');
-	if (!p)
+	p = buf + strcspn(buf, "\r\n");
+	if (!*p)
 		return NULL;
 
 	*p = '\0';

-- 
1.6.3.1.54.g99dd

[PATCH 5/5] MinGW: Fix compiler warning in merge-recursive

From: Steffen Prohaska <hidden>
Date: 2016-06-15 22:46:49

From: Johannes Schindelin <redacted>

GCC 4.4.0 on Windows does not like the format %zu.  It is quite unlikely,
though, that we need more merge bases than a %d can display, so replace
the %zu by a %d.

Signed-off-by: Johannes Schindelin <redacted>
Signed-off-by: Steffen Prohaska <redacted>
---
 builtin-merge-recursive.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/builtin-merge-recursive.c b/builtin-merge-recursive.c
index 703045b..d26a96e 100644
--- a/builtin-merge-recursive.c
+++ b/builtin-merge-recursive.c

@@ -45,8 +45,9 @@ int cmd_merge_recursive(int argc, const char **argv, const char *prefix)
 			bases[bases_count++] = sha;
 		}
 		else
-			warning("Cannot handle more than %zu bases. "
-				"Ignoring %s.", ARRAY_SIZE(bases)-1, argv[i]);
+			warning("Cannot handle more than %d bases. "
+				"Ignoring %s.",
+				(int)ARRAY_SIZE(bases)-1, argv[i]);
 	}
 	if (argc - i != 3) /* "--" "<head>" "<remote>" */
 		die("Not handling anything other than two heads merge.");

-- 
1.6.3.1.54.g99dd

[PATCH 2/5] MinGW: the path separator to split GITPERLLIB is ';' on Win32

From: Steffen Prohaska <hidden>
Date: 2016-06-15 22:46:49

From: Johannes Schindelin <redacted>

Signed-off-by: Johannes Schindelin <redacted>
Signed-off-by: Steffen Prohaska <redacted>
---
 Makefile |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 26d180c..7166760 100644
--- a/Makefile
+++ b/Makefile

@@ -225,6 +225,7 @@ ETC_GITCONFIG = etc/gitconfig
 endif
 lib = lib
 # DESTDIR=
+pathsep = :
 
 # default configuration for gitweb
 GITWEB_CONFIG = gitweb_config.perl

@@ -813,6 +814,7 @@ ifneq (,$(findstring CYGWIN,$(uname_S)))
 	UNRELIABLE_FSTAT = UnfortunatelyYes
 endif
 ifneq (,$(findstring MINGW,$(uname_S)))
+	pathsep = ;
 	NO_PREAD = YesPlease
 	NO_OPENSSL = YesPlease
 	NO_CURL = YesPlease

@@ -1268,7 +1270,7 @@ $(patsubst %.perl,%,$(SCRIPT_PERL)): % : %.perl
 	sed -e '1{' \
 	    -e '	s|#!.*perl|#!$(PERL_PATH_SQ)|' \
 	    -e '	h' \
-	    -e '	s=.*=use lib (split(/:/, $$ENV{GITPERLLIB} || "@@INSTLIBDIR@@"));=' \
+	    -e '	s=.*=use lib (split(/$(pathsep)/, $$ENV{GITPERLLIB} || "@@INSTLIBDIR@@"));=' \
 	    -e '	H' \
 	    -e '	x' \
 	    -e '}' \

-- 
1.6.3.1.54.g99dd

[PATCH 4/5] MinGW: Add a simple getpass()

From: Steffen Prohaska <hidden>
Date: 2016-06-15 22:46:49

From: Johannes Schindelin <redacted>

We need getpass() to activate curl on MinGW.  Although the default
Makefile currently has 'NO_CURL = YesPlease', msysgit releases do
provide curl support, so getpass() is used.

[spr: - edited commit message.
      - squashed commit that provides getpass() declaration.]

Signed-off-by: Johannes Schindelin <redacted>
Signed-off-by: Steffen Prohaska <redacted>
---
 compat/mingw.c |   15 +++++++++++++++
 compat/mingw.h |    2 ++
 2 files changed, 17 insertions(+), 0 deletions(-)

diff --git a/compat/mingw.c b/compat/mingw.c
index b723c4d..e190fdd 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c

@@ -1156,3 +1156,18 @@ int link(const char *oldpath, const char *newpath)
 	}
 	return 0;
 }
+
+char *getpass(const char *prompt)
+{
+	struct strbuf buf = STRBUF_INIT;
+
+	fputs(prompt, stderr);
+	for (;;) {
+		char c = _getch();
+		if (c == '\r' || c == '\n')
+			break;
+		strbuf_addch(&buf, c);
+	}
+	fputs("\n", stderr);
+	return strbuf_detach(&buf, NULL);
+}

diff --git a/compat/mingw.h b/compat/mingw.h
index b1156b8..4c50f5b 100644
--- a/compat/mingw.h
+++ b/compat/mingw.h

@@ -38,6 +38,8 @@ struct passwd {
 	char *pw_dir;
 };
 
+extern char *getpass(const char *prompt);
+
 struct pollfd {
 	int fd;           /* file descriptor */
 	short events;     /* requested events */

-- 
1.6.3.1.54.g99dd

[PATCH 3/5] MinGW: use POSIX signature of waitpid()

From: Steffen Prohaska <hidden>
Date: 2016-06-15 22:46:49

From: Johannes Schindelin <redacted>

Git's source code expects waitpid() to return a signed int status.

Signed-off-by: Johannes Schindelin <redacted>
Signed-off-by: Steffen Prohaska <redacted>
---
 compat/mingw.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/compat/mingw.h b/compat/mingw.h
index 762eb14..b1156b8 100644
--- a/compat/mingw.h
+++ b/compat/mingw.h

@@ -109,7 +109,7 @@ static inline int mingw_unlink(const char *pathname)
 }
 #define unlink mingw_unlink
 
-static inline int waitpid(pid_t pid, unsigned *status, unsigned options)
+static inline int waitpid(pid_t pid, int *status, unsigned options)
 {
 	if (options == 0)
 		return _cwait(status, pid, 0);

-- 
1.6.3.1.54.g99dd

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help