[PATCH] Makefile: ignore perl/ subdirectory under NO_PERL

Subsystems: kernel build + files below scripts/ (unless maintained elsewhere), the rest

DORMANTno replies

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

[PATCH] Makefile: ignore perl/ subdirectory under NO_PERL

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:38

The install target still descends into perl subdirectory when NO_PERL is
requested.  Fix this.

Signed-off-by: Junio C Hamano <redacted>
---

 * I think the very original from Robin had this exclusion, but somehow it
   seems to have got lost.  Right now, perl/Makefile does not do anything
   that depends on having perl, but I think we do not have/need to rely on
   that.

 Makefile |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index 49f36f5..6f602c7 100644
--- a/Makefile
+++ b/Makefile
@@ -1529,7 +1529,9 @@ install: all
 	$(INSTALL) $(ALL_PROGRAMS) '$(DESTDIR_SQ)$(gitexec_instdir_SQ)'
 	$(INSTALL) git$X git-upload-pack$X git-receive-pack$X git-upload-archive$X git-shell$X git-cvsserver '$(DESTDIR_SQ)$(bindir_SQ)'
 	$(MAKE) -C templates DESTDIR='$(DESTDIR_SQ)' install
+ifndef NO_PERL
 	$(MAKE) -C perl prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install
+endif
 ifndef NO_TCLTK
 	$(MAKE) -C gitk-git install
 	$(MAKE) -C git-gui gitexecdir='$(gitexec_instdir_SQ)' install

Re: [PATCH] Makefile: ignore perl/ subdirectory under NO_PERL

From: Jeff King <hidden>
Date: 2016-06-15 22:46:38

On Wed, Apr 22, 2009 at 10:42:28PM -0700, Junio C Hamano wrote:
The install target still descends into perl subdirectory when NO_PERL is
requested.  Fix this.
Oops, good catch.

Acked-by: Jeff King <redacted>

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help