[PATCH] bisect-helper: fix grammatical typo in exit_if_skipped_commits()

Subsystems: the rest

DORMANTno replies

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

[PATCH] bisect-helper: fix grammatical typo in exit_if_skipped_commits()

From: Stephen Boyd <hidden>
Date: 2016-06-15 22:46:38

Signed-off-by: Stephen Boyd <redacted>
---
Christian Couder wrote: 
Le lundi 20 avril 2009, Stephen Boyd a écrit : 
quoted
Christian Couder wrote: 
quoted
+   printf("There are only 'skip'ped commit left to test.\n" 
+          "The first bad commit could be any of:\n") 
Should this be "There are only 'skip'ped commits left to test"? 
Yes, but the same message was printed previously, so it is a slightly  
incompatible change and I think it should go into another patch. Would you  
care to send such a patch? 

Thanks, 
Christian. 
 
This is against pu. 

 bisect.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/bisect.c b/bisect.c
index f6e1378..5902e83 100644
--- a/bisect.c
+++ b/bisect.c
@@ -575,7 +575,7 @@ static void exit_if_skipped_commits(struct commit_list *tried,
 	if (!tried)
 		return;
 
-	printf("There are only 'skip'ped commit left to test.\n"
+	printf("There are only 'skip'ped commits left to test.\n"
 	       "The first bad commit could be any of:\n");
 	print_commit_list(tried, "%s\n", "%s\n");
 	if (bad)
-- 
1.6.2.3

Re: [PATCH] bisect-helper: fix grammatical typo in exit_if_skipped_commits()

From: Christian Couder <hidden>
Date: 2016-06-15 22:46:38

Le mardi 21 avril 2009, Stephen Boyd a écrit :
quoted hunk
This is against pu.

 bisect.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/bisect.c b/bisect.c
index f6e1378..5902e83 100644
--- a/bisect.c
+++ b/bisect.c
@@ -575,7 +575,7 @@ static void exit_if_skipped_commits(struct
commit_list *tried, if (!tried)
 		return;

-	printf("There are only 'skip'ped commit left to test.\n"
+	printf("There are only 'skip'ped commits left to test.\n"
 	       "The first bad commit could be any of:\n");
 	print_commit_list(tried, "%s\n", "%s\n");
 	if (bad)
Acked-by: Christian Couder <redacted>

Thanks,
Christian.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help