Re: [PATCH 3/3] Fix typos / spelling in comments

3 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 3/3] Fix typos / spelling in comments

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:37

Michael J Gruber [off-list ref] writes:
Word based spell checkers can only do what they can...
I think we should use this occasion and have humans at least look at the
context.
Absolutely.  Care to make that into a follow-up incremental patch so that
I can squash it in when I apply this 3/3 patch?

[PATCH] Fix more typos/spelling in comments

From: Michael J Gruber <hidden>
Date: 2016-06-15 22:46:38

A few more fixes on top of the automatic spell checker generated ones.

Signed-off-by: Michael J Gruber <redacted>
---
Sorry it took me so long...

 builtin-reflog.c         |    2 +-
 compat/cygwin.c          |    2 +-
 compat/fnmatch/fnmatch.c |    2 +-
 fast-import.c            |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/builtin-reflog.c b/builtin-reflog.c
index ff8b4f6..ddfdf5a 100644
--- a/builtin-reflog.c
+++ b/builtin-reflog.c
@@ -240,7 +240,7 @@ static int unreachable(struct expire_reflog_cb *cb, struct commit *commit, unsig
 static void mark_reachable(struct commit *commit, unsigned long expire_limit)
 {
 	/*
-	 * We need to compute if commit on either side of an reflog
+	 * We need to compute whether the commit on either side of a reflog
 	 * entry is reachable from the tip of the ref for all entries.
 	 * Mark commits that are reachable from the tip down to the
 	 * time threshold first; we know a commit marked thusly is
diff --git a/compat/cygwin.c b/compat/cygwin.c
index 1192874..b4a51b9 100644
--- a/compat/cygwin.c
+++ b/compat/cygwin.c
@@ -89,7 +89,7 @@ static int cygwin_stat(const char *path, struct stat *buf)
 /*
  * At start up, we are trying to determine whether Win32 API or cygwin stat
  * functions should be used. The choice is determined by core.ignorecygwinfstricks.
- * Reading this option is not always possible immediately as git_dir may be
+ * Reading this option is not always possible immediately as git_dir may
  * not be set yet. So until it is set, use cygwin lstat/stat functions.
  * However, if core.filemode is set, we must use the Cygwin posix
  * stat/lstat as the Windows stat functions do not determine posix filemode.
diff --git a/compat/fnmatch/fnmatch.c b/compat/fnmatch/fnmatch.c
index 03157a4..14feac7 100644
--- a/compat/fnmatch/fnmatch.c
+++ b/compat/fnmatch/fnmatch.c
@@ -39,7 +39,7 @@
 # include <stdlib.h>
 #endif
 
-/* For platform which support the ISO C amendment 1 functionality we
+/* For platforms which support the ISO C amendment 1 functionality we
    support user defined character classes.  */
 #if defined _LIBC || (defined HAVE_WCTYPE_H && defined HAVE_WCHAR_H)
 /* Solaris 2.5 has a bug: <wchar.h> must be included before <wctype.h>.  */
diff --git a/fast-import.c b/fast-import.c
index 53617a1..8d959af 100644
--- a/fast-import.c
+++ b/fast-import.c
@@ -133,7 +133,7 @@ Format of STDIN stream:
      # always escapes the related input from comment processing.
      #
      # In case it is not clear, the '#' that starts the comment
-     # must be the first character on that the line (an lf have
+     # must be the first character on that line (an lf
      # preceded it).
      #
   comment ::= '#' not_lf* lf;
-- 
1.6.3.rc1.34.g0be9b

Re: [PATCH] Fix more typos/spelling in comments

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:38

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help