[PATCH] gitk: avoid crash if closed while reading references

Subsystems: the rest

DORMANTno replies

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

[PATCH] gitk: avoid crash if closed while reading references

From: Pat Thoyts <hidden>
Date: 2016-06-15 22:46:36

  As recorded in msysGit issue 125 if the user closes gitk while it
  reports itself as still reading references then Tk will crash in the
  geometry management code. This has been fixed for Tk 8.5.7 and above.
  This patch avoids the problem by flushing outstanding geometry events
  before calling the readrefs procedure.

  See also http://code.google.com/p/msysgit/issues/detail?id=125

Signed-off-by: Pat Thoyts <redacted>
---
 gitk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gitk b/gitk
index 656c2c1..a346bd5 100755
--- a/gitk
+++ b/gitk
@@ -10952,6 +10952,7 @@ catch {
 # wait for the window to become visible
 tkwait visibility .
 wm title . "[file tail $argv0]: [file tail [pwd]]"
+update
 readrefs
 
 if {$cmdline_files ne {} || $revtreeargs ne {} || $revtreeargscmd ne {}} {
-- 
1.6.2.2.1669.g7eaf8

Re: [PATCH] gitk: avoid crash if closed while reading references

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:46:36

Hi,

On Wed, 15 Apr 2009, Pat Thoyts wrote:
  As recorded in msysGit issue 125 if the user closes gitk while it
  reports itself as still reading references then Tk will crash in the
  geometry management code. This has been fixed for Tk 8.5.7 and above.
  This patch avoids the problem by flushing outstanding geometry events
  before calling the readrefs procedure.

  See also http://code.google.com/p/msysgit/issues/detail?id=125

Signed-off-by: Pat Thoyts <redacted>
This is commit 3d3ecb65e34a62b83648516150ec8a99e1b3ace7 in 4msysgit's 
'devel' branch now, and will be part of the next msysGit release.

Thanks,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help