[PATCH] git-svn: always initialize with core.autocrlf=false

Subsystems: the rest

DORMANTno replies

4 messages, 3 authors, 2016-06-15 · open the first message on its own page

[PATCH] git-svn: always initialize with core.autocrlf=false

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:46:35

It has been reported time and time again in relation to msysGit that
git-svn does not work well when core.autocrlf has any value other than
'false'.  So let's make it so by default.

Signed-off-by: Johannes Schindelin <redacted>
---
 git-svn.perl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 8be6be0..d4e8fc8 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -325,6 +325,7 @@ sub do_git_init_db {
 		command_noisy(@init_db);
 		$_repository = Git->repository(Repository => ".git");
 	}
+	command_noisy('config', 'core.autocrlf', 'false');
 	my $set;
 	my $pfx = "svn-remote.$Git::SVN::default_repo_id";
 	foreach my $i (keys %icv) {
-- 
1.6.2.1.613.g25746

Re: [PATCH] git-svn: always initialize with core.autocrlf=false

From: Eric Wong <hidden>
Date: 2016-06-15 22:46:35

Johannes Schindelin [off-list ref] wrote:
It has been reported time and time again in relation to msysGit that
git-svn does not work well when core.autocrlf has any value other than
'false'.  So let's make it so by default.

Signed-off-by: Johannes Schindelin <redacted>
Acked-by: Eric Wong <redacted>
quoted hunk
---
 git-svn.perl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 8be6be0..d4e8fc8 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -325,6 +325,7 @@ sub do_git_init_db {
 		command_noisy(@init_db);
 		$_repository = Git->repository(Repository => ".git");
 	}
+	command_noisy('config', 'core.autocrlf', 'false');
 	my $set;
 	my $pfx = "svn-remote.$Git::SVN::default_repo_id";
 	foreach my $i (keys %icv) {
-- 
1.6.2.1.613.g25746
-- 
Eric Wong

Re: [PATCH] git-svn: always initialize with core.autocrlf=false

From: Ferry Huberts (Pelagic) <hidden>
Date: 2016-06-15 22:46:35

Eric Wong wrote:
Johannes Schindelin [off-list ref] wrote:
quoted
It has been reported time and time again in relation to msysGit that
git-svn does not work well when core.autocrlf has any value other than
'false'.  So let's make it so by default.

Signed-off-by: Johannes Schindelin <redacted>
Acked-by: Eric Wong <redacted>
quoted
---
 git-svn.perl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 8be6be0..d4e8fc8 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -325,6 +325,7 @@ sub do_git_init_db {
 		command_noisy(@init_db);
 		$_repository = Git->repository(Repository => ".git");
 	}
+	command_noisy('config', 'core.autocrlf', 'false');
 	my $set;
 	my $pfx = "svn-remote.$Git::SVN::default_repo_id";
 	foreach my $i (keys %icv) {
-- 
1.6.2.1.613.g25746
funny that this kind of seems to get through while my suggestion (and
proff by tests) to do the same for the cvs-import stuff resulted in
hefty discussions and no consensus on what to do, the result of which is
to do nothing. i guess i couldn't make myself clear enough?

Re: [PATCH] git-svn: always initialize with core.autocrlf=false

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:46:35

Hi,

On Thu, 9 Apr 2009, Ferry Huberts (Pelagic) wrote:
Eric Wong wrote:
quoted
Johannes Schindelin [off-list ref] wrote:
quoted
It has been reported time and time again in relation to msysGit that
git-svn does not work well when core.autocrlf has any value other than
'false'.  So let's make it so by default.

Signed-off-by: Johannes Schindelin <redacted>
Acked-by: Eric Wong <redacted>
quoted
---
 git-svn.perl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 8be6be0..d4e8fc8 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -325,6 +325,7 @@ sub do_git_init_db {
 		command_noisy(@init_db);
 		$_repository = Git->repository(Repository => ".git");
 	}
+	command_noisy('config', 'core.autocrlf', 'false');
 	my $set;
 	my $pfx = "svn-remote.$Git::SVN::default_repo_id";
 	foreach my $i (keys %icv) {
-- 
1.6.2.1.613.g25746
funny that this kind of seems to get through while my suggestion (and
proff by tests) to do the same for the cvs-import stuff resulted in
hefty discussions and no consensus on what to do, the result of which is
to do nothing. i guess i couldn't make myself clear enough?
Actually, I was very much in favor of it.  Care to resend, for our 
pleasure, pretty please?

Thanks,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help