Re: bsd group semantics

Jeff King [off-list ref] writes:

On Tue, Mar 31, 2009 at 08:55:00AM -0700, Junio C Hamano wrote:
...

quoted

Ideally the test should be checking if the subdirectory is owned by the
same group as the toplevel, but that is rather hard to correctly arrange,
as it depends on the set of groups the user who runs the test belongs to,
how the git work tree is set up (if it is owned by his primary group or a
secondary), etc.

Shouldn't that just be:

  perl -e 'sub group { return (stat(shift))[5] }' \
       -e 'exit group($ARGV[0]) == group($ARGV[1]) ? 0 : 1' \
       a b

?

My point was if I belong only to my personal group and git.git work tree
is owned by junio.junio to begin with, you would never be able to notice
any breakage with such a test.

On Tue, Mar 31, 2009 at 10:32:14AM -0700, Junio C Hamano wrote:

My point was if I belong only to my personal group and git.git work tree
is owned by junio.junio to begin with, you would never be able to notice
any breakage with such a test.

Ah, I see. Yes, you would need to belong to at least two groups to make
such a test feasible.

Such a requirement is generally outside the scope of running the
test suite; do you want to just ditch the g+s test, then, or do you want
me to work up something conditional based on the Makefile flag?

-Peff