Re: [PATCH 1/2] send-email: refactor and ensure prompting doesn't loop forever

Jay Soffian [off-list ref] writes:

Several places in send-email prompt for input, and will do so forever
when the input is EOF. This is poor behavior when send-email is run
unattended (say from cron).

Thanks a lot for the patch, it does fix the problem I reported in
http://article.gmane.org/gmane.comp.version-control.git/114577 .

Minor problem: I still (harmless) get error messages in my log:

  print() on closed filehandle FOUT at /usr/share/perl/5.8/Term/ReadLine.pm line 193.
  readline() on closed filehandle FIN at /usr/share/perl/5.8/Term/ReadLine.pm line 395.
  print() on closed filehandle FOUT at /usr/share/perl/5.8/Term/ReadLine.pm line 203.
  
But I can very well live with them!

-- 
Matthieu

On Mon, Mar 30, 2009 at 7:29 AM, Matthieu Moy [off-list ref] wrote:

Minor problem: I still (harmless) get error messages in my log:

 print() on closed filehandle FOUT at /usr/share/perl/5.8/Term/ReadLine.pm line 193.
 readline() on closed filehandle FIN at /usr/share/perl/5.8/Term/ReadLine.pm line 395.
 print() on closed filehandle FOUT at /usr/share/perl/5.8/Term/ReadLine.pm line 203.

But I can very well live with them!

perl send-email ... 2>/dev/null :-)

Seriously though, I am unable to reproduce the messages you are
getting from Term::ReadLine, and I tried really hard.

What does:

$ perl -e 'use Term::ReadLine; print "$Term::ReadLine::VERSION\n"'

tell you?

Also, thank you for confirming the fix.

j.

On Mon, Mar 30, 2009 at 10:17 AM, Jay Soffian [off-list ref] wrote:

perl send-email ... 2>/dev/null :-)

Hmfph, perl on the mind. That should of course be "git send-email ...
2>/dev/null" but it was only a half-serious suggestion anyway.

j.