Re: [PATCH 1/2] Add a test for checking whether gitattributes is honored by checkout.

Kristian Amlie [off-list ref] writes:

+test_expect_success 'setup' '

If you have two separate patches for test and bugfix, you probably
want the first to introduce test_expect_failure, and the second to
change it to test_expect_success. This way: 1) the test-suite passes
for all commits (and git-bisect will be your friend again), and 2) the
second patch is self-explanatory about the bug it fixes.

-- 
Matthieu

ext Matthieu Moy wrote:

Kristian Amlie [off-list ref] writes:

quoted

+test_expect_success 'setup' '

If you have two separate patches for test and bugfix, you probably
want the first to introduce test_expect_failure, and the second to
change it to test_expect_success. This way: 1) the test-suite passes
for all commits (and git-bisect will be your friend again), and 2) the
second patch is self-explanatory about the bug it fixes.

Good point. I'll fix that in my next batch.

--
Kristian