Re: [PATCH] clone: run post-checkout hook when checking out

Jeff King [off-list ref] writes:

Junio, I'm not sure what you want to do with this. It is definitely a
behavior change; we have never respected post-checkout hooks in shell
git-clone.sh or in the builtin version. However, it seems like an
omission rather than an intentional behavior, so I consider this a
bugfix.

I do not mind queueing this to 'pu' and let people fight it out.  I hate
the local side hooks that have no reason to be there, and consider that
the existence of the "checkout hook" to be a bug to begin with, but I
really don't care that deeply anymore.

On Tue, Mar 3, 2009 at 1:45 AM, Junio C Hamano [off-list ref] wrote:

I do not mind queueing this to 'pu' and let people fight it out.  I hate
the local side hooks that have no reason to be there, and consider that
the existence of the "checkout hook" to be a bug to begin with

I just want to clarify: do you mean to say that none of the local side
hooks have any reason to be there, or that some of the local hooks do
not belong, and checkout is one of those?

j.

On Mon, Mar 02, 2009 at 10:45:09PM -0800, Junio C Hamano wrote:

quoted

Junio, I'm not sure what you want to do with this. It is definitely a
behavior change; we have never respected post-checkout hooks in shell
git-clone.sh or in the builtin version. However, it seems like an
omission rather than an intentional behavior, so I consider this a
bugfix.

I do not mind queueing this to 'pu' and let people fight it out.  I hate
the local side hooks that have no reason to be there, and consider that
the existence of the "checkout hook" to be a bug to begin with, but I
really don't care that deeply anymore.

That sounds fine to me. I don't personally care either way (I didn't
even know we had a post-checkout hook until today).

-Peff

Quoting Jay Soffian [off-list ref]:

On Tue, Mar 3, 2009 at 1:45 AM, Junio C Hamano [off-list ref] wrote:

quoted

I do not mind queueing this to 'pu' and let people fight it out.  I hate
the local side hooks that have no reason to be there, and consider that
the existence of the "checkout hook" to be a bug to begin with

I just want to clarify: do you mean to say that none of the local side
hooks have any reason to be there, or that some of the local hooks do
not belong, and checkout is one of those?

There are five valid reasons you might want a hook to a git operation.

http://thread.gmane.org/gmane.comp.version-control.git/70781/focus=71069

-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/