git-1.6.2-rc2 problems on t4034-diff-words.sh

4 messages, 2 authors, 2016-06-15 · open the first message on its own page

git-1.6.2-rc2 problems on t4034-diff-words.sh

From: Boyd Lynn Gerber <hidden>
Date: 2016-06-15 22:46:18

Hello,

I just download and started to test this on SCO OpenServer 6.0.mp4

They just released a new Maintianence Patch for the OS.  This is what I 
get while running gmake test.

*** t4034-diff-words.sh ***
*   ok 1: setup
*   ok 2: word diff with runs of whitespace
*   ok 3: word diff with a regular expression
*   ok 4: set a diff driver
*   ok 5: option overrides .gitattributes
* FAIL 6: use regex supplied by driver


                 word_diff --color-words


*   ok 7: set diff.wordRegex option
*   ok 8: command-line overrides config
* FAIL 9: .gitattributes override config

                 word_diff --color-words

*   ok 10: remove diff driver regex
*   ok 11: use configured regex
* FAIL 12: test parsing words for newline


                 word_diff --color-words="a+"



* FAIL 13: test when words are only removed at the end


                 word_diff --color-words=.


* failed 4 among 13 test(s)
gmake[2]: *** [t4034-diff-words.sh] Error 1


-- 
Boyd Gerber [off-list ref] 801 849-0213
ZENEZ	1042 East Fort Union #135, Midvale Utah  84047

Re: git-1.6.2-rc2 problems on t4034-diff-words.sh

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:46:18

Hi,

On Fri, 27 Feb 2009, Boyd Lynn Gerber wrote:
I just download and started to test this on SCO OpenServer 6.0.mp4
Oh wow.  SCO...

But as I did not forget your kind words, I'll try to help.
* FAIL 6: use regex supplied by driver


                word_diff --color-words
It might be a regex related issue.  Could you

- run the test with -i -v (and if that does not help, "sh -x t...")?

- try with "make COMPAT_FLAGS=-Icompat/regex COMPAT_OBJS=compat/regex/regex.o"?

Thanks,
Dscho

Re: git-1.6.2-rc2 problems on t4034-diff-words.sh

From: Boyd Lynn Gerber <hidden>
Date: 2016-06-15 22:46:18

Thanks for your assistence.  I try to test each version before release. 
So I want to make sure no changes have broken things.

On Fri, 27 Feb 2009, Johannes Schindelin wrote:
On Fri, 27 Feb 2009, Boyd Lynn Gerber wrote:
quoted
I just download and started to test this on SCO OpenServer 6.0.mp4
Oh wow.  SCO...
Yes, I still have to support some SCO OS's.  I use git on all my OS's.  So 
I want to make sure it works on all of them.
But as I did not forget your kind words, I'll try to help.
quoted
* FAIL 6: use regex supplied by driver


                word_diff --color-words
Does the test suite use bash as it's shell?  I seem to have to use bash 
now to run the test.  I do not remember having to use bash on earlier 
1.6.0
It might be a regex related issue.  Could you

- run the test with -i -v (and if that does not help, "sh -x t...")?
I have to use bash to run the test or I get

$ ./t4034-diff-words.sh
./t4034-diff-words.sh: syntax error at line 52: `(' unexpected

But if I run

$ bash ./t4034-diff-words.sh
*   ok 1: setup
*   ok 2: word diff with runs of whitespace
*   ok 3: word diff with a regular expression
*   ok 4: set a diff driver
*   ok 5: option overrides .gitattributes
* FAIL 6: use regex supplied by driver


                 word_diff --color-words


*   ok 7: set diff.wordRegex option
*   ok 8: command-line overrides config
* FAIL 9: .gitattributes override config

                 word_diff --color-words

*   ok 10: remove diff driver regex
*   ok 11: use configured regex
* FAIL 12: test parsing words for newline


                 word_diff --color-words="a+"



* FAIL 13: test when words are only removed at the end


                 word_diff --color-words=.


* failed 4 among 13 test(s)
$ bash ./t4034-diff-words.sh -i -v
Initialized empty Git repository in /tmp/git-1.6.2.rc2/t/trash 
directory.t4034-diff-words/.git/
* expecting success:

         git config diff.color.old red
         git config diff.color.new green


*   ok 1: setup

* expecting success:

         word_diff --color-words


*   ok 2: word diff with runs of whitespace

* expecting success:

         word_diff --color-words="[a-z]+"


*   ok 3: word diff with a regular expression

* expecting success:
         git config diff.testdriver.wordRegex "[^[:space:]]" &&
         cat <<EOF > .gitattributes
pre diff=testdriver
post diff=testdriver
EOF

*   ok 4: set a diff driver

* expecting success:

         word_diff --color-words="[a-z]+"


*   ok 5: option overrides .gitattributes

* expecting success:

         word_diff --color-words


Binary files expect and output.decrypted differ
* FAIL 6: use regex supplied by driver


                 word_diff --color-words




Binary files expect and output.decrypted differ
* FAIL 6: use regex supplied by driver


                 word_diff --color-words
- try with "make COMPAT_FLAGS=-Icompat/regex COMPAT_OBJS=compat/regex/regex.o"?
$ gmake COMPAT_FLAGS=-Icompat/regex COMPAT_OBJS=compat/regex/regex.o
     CC compat/regex/regex.o
     AR libgit.a
     LINK git-fast-import
Undefined                       first referenced
symbol                              in file
git_fopen                           fast-import.o
git_vsnprintf                       fast-import.o
git_snprintf                        fast-import.o
UX:ld: ERROR: Symbol referencing errors. No output written to 
git-fast-import
gmake: *** [git-fast-import] Error 1

-- 
Boyd Gerber [off-list ref] 801 849-0213
ZENEZ	1042 East Fort Union #135, Midvale Utah  84047

Re: git-1.6.2-rc2 problems on t4034-diff-words.sh

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:46:18

Hi,

On Fri, 27 Feb 2009, Boyd Lynn Gerber wrote:
On Fri, 27 Feb 2009, Johannes Schindelin wrote:
quoted
But as I did not forget your kind words, I'll try to help.
quoted
* FAIL 6: use regex supplied by driver


                word_diff --color-words
Does the test suite use bash as it's shell?  I seem to have to use bash 
now to run the test.  I do not remember having to use bash on earlier 
1.6.0
No, bash should not be required.
quoted
It might be a regex related issue.  Could you

- run the test with -i -v (and if that does not help, "sh -x t...")?
I have to use bash to run the test or I get

$ ./t4034-diff-words.sh
./t4034-diff-words.sh: syntax error at line 52: `(' unexpected
Could you tell me what your version of t4034 has at line 52?  Mine does 
not have a single parenthesis on that line.
But if I run

$ bash ./t4034-diff-words.sh
*   ok 1: setup
*   ok 2: word diff with runs of whitespace
*   ok 3: word diff with a regular expression
*   ok 4: set a diff driver
*   ok 5: option overrides .gitattributes
* FAIL 6: use regex supplied by driver


                word_diff --color-words
Could you run it again after appending "-i -v" to the command line?

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help