Re: [PATCH] Add tests for git log --pretty, --format and --oneline.

Jeff King [off-list ref] writes:

On Wed, Feb 25, 2009 at 01:54:30AM -0800, Junio C Hamano wrote:

quoted

Because 4202 seems to be about testing the log functionality and they rely
on correctly working format output to verify other aspects of the
operation of "git log", I initially was not sure if this is the right
place to add these new tests.  After looking around I didn't find any
existing test that checks the various --pretty output formats that the new
tests can be added, so this probably is as good a place as any.

t6006?

Good eyes.  But sorry I've already queued the four patches to 'next' and
pushed the result out.  It probably is not worth moving the tests between
two files as a follow-up patch.

On Wed, Feb 25, 2009 at 02:16:40AM -0800, Junio C Hamano wrote:

quoted

quoted

Because 4202 seems to be about testing the log functionality and they rely
on correctly working format output to verify other aspects of the
operation of "git log", I initially was not sure if this is the right
place to add these new tests.  After looking around I didn't find any
existing test that checks the various --pretty output formats that the new
tests can be added, so this probably is as good a place as any.

t6006?

Good eyes.  But sorry I've already queued the four patches to 'next' and
pushed the result out.  It probably is not worth moving the tests between
two files as a follow-up patch.

Good memory; I wrote t6006. ;)

I don't think it is a big deal. I actually thought of it when I read the
original patch but decided not to say anything. t6006 is really about
exercising the formats themselves, so you could argue that the new tests
go just as well in either spot.

-Peff