git-grep: small suggestion, -w flag

5 messages, 3 authors, 2016-06-15 · open the first message on its own page

git-grep: small suggestion, -w flag

From: Ingo Molnar <hidden>
Date: 2016-06-15 22:46:15

Here's a stupid little git-grep suggestion.

I recently transitioned from the use of egrep to git-grep, and i 
like it very much (it nicely excludes build related files, 
etc.), but there's one small detail: the lack of the -w flag.

It's equivalent to this pattern:

   git grep '\<tick_length\>'

And it's the most common grep flag i (and i suspect many others) 
use, in addition to the (already supported) -l flag.

When grepping for symbols in a large repository (such as the 
Linux kernel) -w is very common and very useful - there's many 
similar symbols, variants of each other. I use it when seeing a 
symbol in an oops, etc.

While i realize that git-grep does not want to be a full grep 
replacement, there's a real usability difference between having 
to type:

   git grep '\<schedule\>'
   git grep -w schedule

(especially since backslash is a seldom used key during a normal 
workflow, so accessing it is often a small mental hickup.)

	Ingo

Re: git-grep: small suggestion, -w flag

From: René Scharfe <hidden>
Date: 2016-06-15 22:46:15

Ingo Molnar schrieb:
Here's a stupid little git-grep suggestion.

I recently transitioned from the use of egrep to git-grep, and i 
like it very much (it nicely excludes build related files, 
etc.), but there's one small detail: the lack of the -w flag.
git grep knows this flag since version 1.4.1.  Does it do something
different from egrep's?

René

Re: git-grep: small suggestion, -w flag

From: Ingo Molnar <hidden>
Date: 2016-06-15 22:46:15

* René Scharfe [off-list ref] wrote:
Ingo Molnar schrieb:
quoted
Here's a stupid little git-grep suggestion.

I recently transitioned from the use of egrep to git-grep, and i 
like it very much (it nicely excludes build related files, 
etc.), but there's one small detail: the lack of the -w flag.
git grep knows this flag since version 1.4.1.  Does it do 
something different from egrep's?
ah:

 earth4:~/tip> git grep -lw schedule
 usage: git grep <option>* [-e] <pattern> <rev>* [[--] <path>...]


should have been 'git grep -l -w schedule'.

	Ingo

Re: git-grep: small suggestion, -w flag

From: Miklos Vajna <hidden>
Date: 2016-06-15 22:46:15

On Sun, Feb 22, 2009 at 05:14:10PM +0100, Ingo Molnar [off-list ref] wrote:
 earth4:~/tip> git grep -lw schedule
 usage: git grep <option>* [-e] <pattern> <rev>* [[--] <path>...]


should have been 'git grep -l -w schedule'.
Yeah, that's because git-grep does not use parseopt yet.

I'm willing to work on it once mv/parseopt-ls-files is settled down.

Re: git-grep: small suggestion, -w flag

From: Ingo Molnar <hidden>
Date: 2016-06-15 22:46:15

* Miklos Vajna [off-list ref] wrote:
On Sun, Feb 22, 2009 at 05:14:10PM +0100, Ingo Molnar [off-list ref] wrote:
quoted
 earth4:~/tip> git grep -lw schedule
 usage: git grep <option>* [-e] <pattern> <rev>* [[--] <path>...]


should have been 'git grep -l -w schedule'.
Yeah, that's because git-grep does not use parseopt yet.

I'm willing to work on it once mv/parseopt-ls-files is settled 
down.
As long as it's planned eventually i'm a happy camper! No rush.

	Ingo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help