Re: [PATCH v2 3/8] config: Use parseopt.

4 messages, 3 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH v2 3/8] config: Use parseopt.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:13

I've queued the entire series on top of fc/config-editor topic and even
merged the result in 'pu' once, but I had to reintegrate 'pu' without the
series.

Before this commit, t/t1300-repo-config.sh passes, but this one breaks
the test.

Re: [PATCH v2 3/8] config: Use parseopt.

From: Felipe Contreras <hidden>
Date: 2016-06-15 22:46:13

On Tue, Feb 17, 2009 at 7:44 AM, Junio C Hamano [off-list ref] wrote:
I've queued the entire series on top of fc/config-editor topic and even
merged the result in 'pu' once, but I had to reintegrate 'pu' without the
series.

Before this commit, t/t1300-repo-config.sh passes, but this one breaks
the test.
Ah, I didn't know there was a test for that.

I've fixed most the issues but unfortunately parseopt barfs when -1 is
used as an argument. That should be fixed somehow, otherwise this
patch will never pass the test.

I'm attaching a patch that makes the test pass (for review), but
shouldn't be merged.

-- 
Felipe Contreras

Re: [PATCH v2 3/8] config: Use parseopt.

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:46:13

Hi,

On Tue, 17 Feb 2009, Felipe Contreras wrote:
On Tue, Feb 17, 2009 at 7:44 AM, Junio C Hamano [off-list ref] wrote:
quoted
I've queued the entire series on top of fc/config-editor topic and even
merged the result in 'pu' once, but I had to reintegrate 'pu' without the
series.

Before this commit, t/t1300-repo-config.sh passes, but this one breaks
the test.
Ah, I didn't know there was a test for that.

I've fixed most the issues but unfortunately parseopt barfs when -1 is
used as an argument. That should be fixed somehow, otherwise this
patch will never pass the test.
Have you seen PARSE_OPT_STOP_AT_NON_OPTION?

Ciao,
Dscho

Re: [PATCH v2 3/8] config: Use parseopt.

From: Felipe Contreras <hidden>
Date: 2016-06-15 22:46:13

On Tue, Feb 17, 2009 at 1:55 PM, Johannes Schindelin
[off-list ref] wrote:
Hi,

On Tue, 17 Feb 2009, Felipe Contreras wrote:
quoted
On Tue, Feb 17, 2009 at 7:44 AM, Junio C Hamano [off-list ref] wrote:
quoted
I've queued the entire series on top of fc/config-editor topic and even
merged the result in 'pu' once, but I had to reintegrate 'pu' without the
series.

Before this commit, t/t1300-repo-config.sh passes, but this one breaks
the test.
Ah, I didn't know there was a test for that.

I've fixed most the issues but unfortunately parseopt barfs when -1 is
used as an argument. That should be fixed somehow, otherwise this
patch will never pass the test.
Have you seen PARSE_OPT_STOP_AT_NON_OPTION?
Thanks, that works... cooking up a new series.

-- 
Felipe Contreras
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help