[PATCH] Drop double-semicolon in C
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:08
Subsystem:
the rest · Maintainer:
Linus Torvalds
The worst offenders are "continue;;" and "break;;" in switch statements. Signed-off-by: Junio C Hamano <redacted> --- * I think this is very trivial. You can use $ git grep -n -e ';;' --and --not -e 'for *(.*;;' -- '*.c' to verify I caught all the bad ones. fast-import.c | 2 +- rerere.c | 2 +- tree.c | 2 +- walker.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/fast-import.c b/fast-import.c
index 03b13e0..3ef3413 100644
--- a/fast-import.c
+++ b/fast-import.c@@ -869,7 +869,7 @@ static char *create_index(void) /* Generate the fan-out array. */ c = idx; for (i = 0; i < 256; i++) { - struct object_entry **next = c;; + struct object_entry **next = c; while (next < last) { if ((*next)->sha1[0] != i) break;
diff --git a/rerere.c b/rerere.c
index 718fb52..3518207 100644
--- a/rerere.c
+++ b/rerere.c@@ -290,7 +290,7 @@ static int do_plain_rerere(struct string_list *rr, int fd) hex = xstrdup(sha1_to_hex(sha1)); string_list_insert(path, rr)->util = hex; if (mkdir(git_path("rr-cache/%s", hex), 0755)) - continue;; + continue; handle_file(path, NULL, rr_path(hex, "preimage")); fprintf(stderr, "Recorded preimage for '%s'\n", path); }
diff --git a/tree.c b/tree.c
index dfe4d5f..25d2e29 100644
--- a/tree.c
+++ b/tree.c@@ -110,7 +110,7 @@ int read_tree_recursive(struct tree *tree, case 0: continue; case READ_TREE_RECURSIVE: - break;; + break; default: return -1; }
diff --git a/walker.c b/walker.c
index 679adab..e57630e 100644
--- a/walker.c
+++ b/walker.c@@ -18,7 +18,7 @@ void walker_say(struct walker *walker, const char *fmt, const char *hex) static void report_missing(const struct object *obj) { char missing_hex[41]; - strcpy(missing_hex, sha1_to_hex(obj->sha1));; + strcpy(missing_hex, sha1_to_hex(obj->sha1)); fprintf(stderr, "Cannot obtain needed %s %s\n", obj->type ? typename(obj->type): "object", missing_hex); if (!is_null_sha1(current_commit_sha1))
--
1.6.2.rc0.36.g8307