[PATCH] Make tig call the correct git config command

2009/2/7 Mikael Magnusson [off-list ref]:

2009/2/5 Jonas Fonseca [off-list ref]:

quoted

Hello,

Here is a much needed update fixing multiple regressions from the
introduction of the IO API in 0.13. Among improvements is the much
requested ability to restore the position in the stage view when staging
diff hunks. Also noteworthy is the many optimizations of the screen
updating to make it work better across slow links. Finally, beware that
a handful of incompatibilities can cause problems.

I'm having a problem with tig taking 2 seconds to start up, which
seems to be related to the 'typo checking' feature of git. After
figuring out how to stop strace from helpfully saying
write(2, "WARNING: You called a Git program"..., 137) = 137
I got this (with -s 100):
[pid 29708] write(2, "WARNING: You called a Git program named 'git
config', which does not exist.\nContinuing under the assu"..., 137) =
137
[pid 29708] write(2, "in 2.0 seconds automatically...\n"..., 32) = 32

The output however also contains lots of git config strings, which is
confusing. Is tig running git config twice and failing one of the
times? (Running git config from the cmdline works fine).

Turns out it was as simple as this:

diff --git a/configure.ac b/configure.ac
index b179389..bdea8de 100644
--- a/configure.ac
+++ b/configure.ac

@@ -28,7 +28,7 @@ AC_MSG_CHECKING([which config
 GIT_CONFIG="repo-config"
 git config --list >/dev/null && GIT_CONFIG="config"
 AC_MSG_RESULT([$GIT_CONFIG])
-AC_DEFINE_UNQUOTED(GIT_CONFIG,"$GIT_CONFIG",[git config subcommand])
+AC_DEFINE_UNQUOTED(GIT_CONFIG,"$GIT_CONFIG",[config subcommand])

 AC_CHECK_PROGS(ASCIIDOC, [asciidoc false])
 AC_CHECK_PROGS(XMLTO, [xmlto false])

-- 
Mikael Magnusson

As it turns out I'm an idiot, that's just the configure help message.
Rerunning autoconf + configure in fact generates a completely correct
commandline. Sorry about the noise.

2009/2/8 Mikael Magnusson [off-list ref]:

-- 
Mikael Magnusson

On Sun, Feb 8, 2009 at 08:49, Mikael Magnusson [off-list ref] wrote:

As it turns out I'm an idiot, that's just the configure help message.
Rerunning autoconf + configure in fact generates a completely correct
commandline. Sorry about the noise.

Thanks for checking anyway. The Makefile doesn't detect out-of-date
configure scripts, which (after the move to use argv arrays and execv
in tig-0.13) caused tig to run: "'git' 'git config'" on startup.

I wonder if this check in configure should not be removed anyway,
since it is starting to be a long time since git-repo-config was
renamed.

-- 
Jonas Fonseca

2009/2/8 Jonas Fonseca [off-list ref]

I wonder if this check in configure should not be removed anyway,
since it is starting to be a long time since git-repo-config was
renamed.

Speaking from a packaging standpoint,  as this is the only reason
git-core is a build dependency I would vote to get rid of it.

(I currently already patch the configure so I can build without git-core
installed)

Kris Shannon [off-list ref] wrote Wed, Feb 18, 2009:

2009/2/8 Jonas Fonseca [off-list ref]

quoted

I wonder if this check in configure should not be removed anyway,
since it is starting to be a long time since git-repo-config was
renamed.

Speaking from a packaging standpoint,  as this is the only reason
git-core is a build dependency I would vote to get rid of it.

(I currently already patch the configure so I can build without git-core
installed)

Where can I get your patch?

-- 
Jonas Fonseca