Re: [PATCH v2 3/5] chain kill signals for cleanup functions

3 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH v2 3/5] chain kill signals for cleanup functions

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:04

Jeff King [off-list ref] writes:
On Fri, Jan 30, 2009 at 09:13:00AM +0100, Johannes Sixt wrote:
quoted
Jeff King schrieb:
quoted
One fix would be to just "signal(SIGINT, SIG_DFL)" at the top. But I
think it makes the test cleaner to just switch to a more reliable
signal. The patch would look something like what is below. But I need to
know what exit code Windows generates for SIGTERM. Johannes?
The same as with SIGINT: 3.
Hmm. Clever.

Junio, can you apply this on top of the jk/signal-cleanup topic?
Will do, but I've been sick today, haven't caught up with the list
traffic, and I do not think I'll be reading my mails for the rest of the
day either.  It may take some time for it to appear in the public
repositories.

Thanks.

Re: [PATCH v2 3/5] chain kill signals for cleanup functions

From: Jeff King <hidden>
Date: 2016-06-15 22:46:04

On Fri, Jan 30, 2009 at 04:28:39PM -0800, Junio C Hamano wrote:
quoted
Hmm. Clever.

Junio, can you apply this on top of the jk/signal-cleanup topic?
Will do, but I've been sick today, haven't caught up with the list
traffic, and I do not think I'll be reading my mails for the rest of the
day either.  It may take some time for it to appear in the public
repositories.
No problem. It really is a fix for a false negative in the test, not any
actual git bug, so no rush.

Now I'm off to go make fun of you, buried deep in a thread where you
won't see it.

-Peff

Re: [PATCH v2 3/5] chain kill signals for cleanup functions

From: Jeff King <hidden>
Date: 2016-06-15 22:46:04

On Fri, Jan 30, 2009 at 08:44:20PM -0500, Jeff King wrote:
quoted
Will do, but I've been sick today, haven't caught up with the list
traffic, and I do not think I'll be reading my mails for the rest of the
day either.  It may take some time for it to appear in the public
repositories.
[...]
Now I'm off to go make fun of you, buried deep in a thread where you
won't see it.
Hmm, reading that again, it sounds mean, and I didn't mean it that way.
I should have put a ";P" at the end. What I meant was "while the cat is
away, the mice will play" (i.e., make mischief while our benevolent
dictator is out of commission).

Hope you feel better soon.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help