Re: [PATCH 2/2] http-push: remove MOVE step after PUT when sending objects to server

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 2/2] http-push: remove MOVE step after PUT when sending objects to server

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:59

Johannes Schindelin [off-list ref] writes:
The point is: the repository inside the document root of the web server is 
still a valid repository.

And the assumption is that whenever you have a file that looks like a 
valid object/pack inside a valid repository, that it does not need 
replacing.

So even when optimizing the uncommon (HTTP push is 2nd class citizen), we 
have to keep the common workflow intact (1st class citizens _are_ push by 
file system, ssh or git://).
The first class citizens are "local use", not "copying out of the area
that looks like a repository only to http:// transport users".
Which unfortunately means that put && move must stay.
I still do not understand why it is unfortunate.

As far as I understand, Ray's issue was that his filesystem did not like
the temporary file name that is used for the initial "put" phase because
it contained a character it did not like (colon, perhaps).  Why isn't the
patch about changing _that_ single issue?

Re: [PATCH 2/2] http-push: remove MOVE step after PUT when sending objects to server

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:45:59

Hi,

On Sun, 18 Jan 2009, Junio C Hamano wrote:
Johannes Schindelin [off-list ref] writes:
quoted
Which unfortunately means that put && move must stay.
I still do not understand why it is unfortunate.
Because it is slow.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help