Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote

4 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:58

"Shawn O. Pearce" [off-list ref] writes:
Markus Heidelberg [off-list ref] wrote:
quoted
Signed-off-by: Markus Heidelberg <redacted>
Acked-by: Shawn O. Pearce <redacted>
quoted
	I've just accidently read in the completion file itself, that
	Shawn is the maintainer, so I give it a third try. The first two
	haven't been sent to him.
Sorry, I must have missed the other two attempts.  :-)
And I seem to have missed all three.
 
quoted
 contrib/completion/git-completion.bash |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 049ded0..6623344 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1384,7 +1384,7 @@ _git_config ()
 
 _git_remote ()
 {
-	local subcommands="add rm show prune update"
+	local subcommands="add rename rm show prune update"
 	local subcommand="$(__git_find_subcommand "$subcommands")"
 	if [ -z "$subcommand" ]; then
 		__gitcomp "$subcommands"
@@ -1392,7 +1392,7 @@ _git_remote ()
 	fi
 
 	case "$subcommand" in
-	rm|show|prune)
+	rename|rm|show|prune)
 		__gitcomp "$(__git_remotes)"
 		;;
 	update)
-- 
1.6.1.35.g0c23
-- 
Shawn.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote

From: Markus Heidelberg <hidden>
Date: 2016-06-15 22:45:59

Junio C Hamano, 17.01.2009:
"Shawn O. Pearce" [off-list ref] writes:
quoted
Markus Heidelberg [off-list ref] wrote:
quoted
Signed-off-by: Markus Heidelberg <redacted>
Acked-by: Shawn O. Pearce <redacted>
quoted
	I've just accidently read in the completion file itself, that
	Shawn is the maintainer, so I give it a third try. The first two
	haven't been sent to him.
Sorry, I must have missed the other two attempts.  :-)
And I seem to have missed all three.
I really don't like to bother you again, but compared to the inclusion
of the other patches, I guess you have forgotten the third try of this
patch.

Thus this fourth try :)

Markus

quoted
quoted
 contrib/completion/git-completion.bash |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 049ded0..6623344 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1384,7 +1384,7 @@ _git_config ()
 
 _git_remote ()
 {
-	local subcommands="add rm show prune update"
+	local subcommands="add rename rm show prune update"
 	local subcommand="$(__git_find_subcommand "$subcommands")"
 	if [ -z "$subcommand" ]; then
 		__gitcomp "$subcommands"
@@ -1392,7 +1392,7 @@ _git_remote ()
 	fi
 
 	case "$subcommand" in
-	rm|show|prune)
+	rename|rm|show|prune)
 		__gitcomp "$(__git_remotes)"
 		;;
 	update)
-- 
1.6.1.35.g0c23

Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:59

Markus Heidelberg [off-list ref] writes:
Junio C Hamano, 17.01.2009:
quoted
"Shawn O. Pearce" [off-list ref] writes:
quoted
Markus Heidelberg [off-list ref] wrote:
quoted
Signed-off-by: Markus Heidelberg <redacted>
Acked-by: Shawn O. Pearce <redacted>
quoted
	I've just accidently read in the completion file itself, that
	Shawn is the maintainer, so I give it a third try. The first two
	haven't been sent to him.
Sorry, I must have missed the other two attempts.  :-)
And I seem to have missed all three.
I really don't like to bother you again, but compared to the inclusion
of the other patches, I guess you have forgotten the third try of this
patch.

Thus this fourth try :)
I did not mean that I forgot by the above "I seem to have missed".
Literally none of your three attempts seem to have reached me.  I can
guess what you wrote from the _included_ text in Shawn's response, but
that is not a good/right place for me to pick up a patch from, is it?

Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote

From: Markus Heidelberg <hidden>
Date: 2016-06-15 22:46:00

Signed-off-by: Markus Heidelberg <redacted>
Acked-by: Shawn O. Pearce <redacted>
---
quoted
I really don't like to bother you again, but compared to the inclusion
of the other patches, I guess you have forgotten the third try of this
patch.

Thus this fourth try :)
I did not mean that I forgot by the above "I seem to have missed".
Literally none of your three attempts seem to have reached me.
Ah, OK. With "missed" I thought you have just overlooked them.
I can
guess what you wrote from the _included_ text in Shawn's response, but
that is not a good/right place for me to pick up a patch from, is it?
No, it isn't.


next mail:
I just don't get it. The previous mail, I sent three a half hours ago,
didn't reach the list either. Am I doing anything wrong?  I looked at
the archives: the first two got to the list, the 3rd (with the Acked-by
from Shawn) and 4th didn't. Now this is the 5th. I can't remember any
such problems with mail delivery.


 contrib/completion/git-completion.bash |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 3ce6de2..f2d6cad 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1391,7 +1391,7 @@ _git_config ()
 
 _git_remote ()
 {
-	local subcommands="add rm show prune update"
+	local subcommands="add rename rm show prune update"
 	local subcommand="$(__git_find_subcommand "$subcommands")"
 	if [ -z "$subcommand" ]; then
 		__gitcomp "$subcommands"
@@ -1399,7 +1399,7 @@ _git_remote ()
 	fi
 
 	case "$subcommand" in
-	rm|show|prune)
+	rename|rm|show|prune)
 		__gitcomp "$(__git_remotes)"
 		;;
 	update)
-- 
1.6.1.227.gad9c0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help