[PATCH] t7500-commit.sh: do not call test_set_editor unnecessarily, it's confusing
From: Adeodato Simó <hidden>
Date: 2016-06-15 22:45:50
Subsystem:
the rest · Maintainer:
Linus Torvalds
Signed-off-by: Adeodato Simó <redacted> --- I was reading this test case, and it took a small bit to figure out the editor was not being used at all. I hope there was no hidden reason for it to be there, and it can go away. Cheers, t/t7500-commit.sh | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/t/t7500-commit.sh b/t/t7500-commit.sh
index 6e18a96..5998baf 100755
--- a/t/t7500-commit.sh
+++ b/t/t7500-commit.sh@@ -149,10 +149,7 @@ EOF test_expect_success '--signoff' ' echo "yet another content *narf*" >> foo && - echo "zort" | ( - test_set_editor "$TEST_DIRECTORY"/t7500/add-content && - git commit -s -F - foo - ) && + echo "zort" | git commit -s -F - foo && git cat-file commit HEAD | sed "1,/^$/d" > output && test_cmp expect output '
--
1.6.1.307.g07803