[PATCH] builtin-shortlog.c: do not unnecessarily strdup before insertion in list
From: Adeodato Simó <hidden>
Date: 2016-06-15 22:45:49
Subsystem:
the rest · Maintainer:
Linus Torvalds
The log->list always has "strdup_strings" activated, hence strdup'ing namebuf was unnecessary. This change also removes a latent memory leak in the old code. Signed-off-by: Adeodato Simó <redacted> --- builtin-shortlog.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/builtin-shortlog.c b/builtin-shortlog.c
index 4c5d761..90e76ae 100644
--- a/builtin-shortlog.c
+++ b/builtin-shortlog.c@@ -67,12 +67,9 @@ static void insert_one_record(struct shortlog *log, snprintf(namebuf + len, room, " %.*s", maillen, boemail); } - buffer = xstrdup(namebuf); - item = string_list_insert(buffer, &log->list); + item = string_list_insert(namebuf, &log->list); if (item->util == NULL) item->util = xcalloc(1, sizeof(struct string_list)); - else - free(buffer); /* Skip any leading whitespace, including any blank lines. */ while (*oneline && isspace(*oneline))
--
1.6.0.4