[StGit PATCH] Do not append a new line to the backwards compat files (bug #12656)

Subsystems: the rest

DORMANTno replies

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

[StGit PATCH] Do not append a new line to the backwards compat files (bug #12656)

From: Catalin Marinas <hidden>
Date: 2016-06-15 22:45:43

Since the multiline argument wasn't passed to the utils.write_string()
function when writing the compatibility description file from the new
infrastructure, any older command like push would have committed these
new lines.

Signed-off-by: Catalin Marinas <redacted>
---
 stgit/lib/stack.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/stgit/lib/stack.py b/stgit/lib/stack.py
index 47679b6..a72ee22 100644
--- a/stgit/lib/stack.py
+++ b/stgit/lib/stack.py
@@ -58,7 +58,7 @@ class Patch(object):
         write('authdate', d.author.date)
         write('commname', d.committer.name)
         write('commemail', d.committer.email)
-        write('description', d.message)
+        write('description', d.message, multiline = True)
         write('log', write_patchlog().sha1)
         write('top', new_commit.sha1)
         write('bottom', d.parent.sha1)

Re: [StGit PATCH] Do not append a new line to the backwards compat files (bug #12656)

From: Karl Hasselström <hidden>
Date: 2016-06-15 22:45:43

On 2008-12-02 14:38:39 +0000, Catalin Marinas wrote:
Since the multiline argument wasn't passed to the
utils.write_string() function when writing the compatibility
description file from the new infrastructure, any older command like
push would have committed these new lines.

Signed-off-by: Catalin Marinas <redacted>
Acked-by: Karl Hasselström <redacted>

Thanks.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help