Re: [minor usability suggestion] git rebase <upstream> --onto <newbase> ?

Ingo Molnar [off-list ref] writes:

 earth4:~/tip> git rebase 685aebb --onto linus
 Current branch core/urgent is up to date.
...
For example "git log" is exemplary in this area as it accepts just 
about any permutation of parameters thrown at it, ...

Not really.

There may be oddball commands whose parameter order have been established
differently long before "git log" came, but almost all of them now use the
same convention used by the "git log" family, which is flags/options then
revs (and then paths if the operation makes sense with paths).  And rebase
is not one of the oddball ones.

Your "rebase" example is a rev then a flag/option, which is not how any
other git command take its command line parameters.

Or at least we should print some sort of warning/error?

With that I agree with.  Patches? ;-)

On Fri, 7 Nov 2008, Junio C Hamano wrote:

Ingo Molnar [off-list ref] writes:

quoted

 earth4:~/tip> git rebase 685aebb --onto linus
 Current branch core/urgent is up to date.
...
For example "git log" is exemplary in this area as it accepts just 
about any permutation of parameters thrown at it, ...

Not really.

There may be oddball commands whose parameter order have been established
differently long before "git log" came, but almost all of them now use the
same convention used by the "git log" family, which is flags/options then
revs (and then paths if the operation makes sense with paths).  And rebase
is not one of the oddball ones.

Your "rebase" example is a rev then a flag/option, which is not how any
other git command take its command line parameters.

"git log origin/master -p" works, though. It's paths, not revisions, that 
can't appear before options (or revisions).

	-Daniel
*This .sig left intentionally blank*