Alex Riesen [off-list ref] writes:
Junio C Hamano, Mon, Oct 27, 2008 06:07:24 +0100:
quoted
Where is git_snpath() used?
Nowhere yet, but it should replace git_path in every call where the
result is not used immediately. Which, as the story with cygwin
porting shows, can be sometimes not quite trivial (who could suspect
lstat(2) will have application local side effects?).
Maybe I should resend the patches without it, following by patches
introducing git_snpath and replacing calls to git_path.
I took the liberty of doing the first half of just that ;-)
I also think this series of fix is maint-worthy, and splitted the last one
into two so that maint and master can be fixed independently.
2008/10/28 Junio C Hamano [off-list ref]:
Alex Riesen [off-list ref] writes:
quoted
Maybe I should resend the patches without it, following by patches
introducing git_snpath and replacing calls to git_path.
I took the liberty of doing the first half of just that ;-)
Thanks. And am sorry... I did that too, and stupidly forgot to send.
I also considered replacing xstrdup(mkpath) with a function which does
just that (patches 8-9). Patches 1 and 2 are unrelated, will send them
separately.
FWIW now, I'm sending the patches.
Alex Riesen, Tue, Oct 28, 2008 13:47:21 +0100:
2008/10/28 Junio C Hamano [off-list ref]:
quoted
Alex Riesen [off-list ref] writes:
quoted
Maybe I should resend the patches without it, following by patches
introducing git_snpath and replacing calls to git_path.
I took the liberty of doing the first half of just that ;-)
Thanks. And am sorry... I did that too, and stupidly forgot to send.
I also considered replacing xstrdup(mkpath) with a function which does
just that (patches 8-9). Patches 1 and 2 are unrelated, will send them
separately.
FWIW now, I'm sending the patches.
Err... The builtin-revert.c hunk of path 0009 depends on the patch I
sent later: "Plug a memleak in builtin-revert". The patch removed const
in front of "char *defmsg".