Re: [PATCH 4/7] textconv: don't convert for every operation

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 4/7] textconv: don't convert for every operation

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:31

Another place that would benefit from ALLOW_TEXTCONV is the function
wt_status_print_verbose() in wt-status.c, where we generate preview diff
for "git commit -v".  The output from that function is purely for human
consumption and does not have to be applicable.

Re: [PATCH 4/7] textconv: don't convert for every operation

From: Jeff King <hidden>
Date: 2016-06-15 22:45:31

On Sat, Oct 25, 2008 at 04:48:19PM -0700, Junio C Hamano wrote:
Another place that would benefit from ALLOW_TEXTCONV is the function
wt_status_print_verbose() in wt-status.c, where we generate preview diff
for "git commit -v".  The output from that function is purely for human
consumption and does not have to be applicable.
I agree, but it turned out not to be as straightforward as I had hoped,
since status doesn't even parse diff.* config.  See patches 7 and 8 in
the series I just posted.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help