DORMANTno replies

[PATCH] git-gui: Show a round number of bytes of large untracked text files

From: Johannes Sixt <hidden>
Date: 2016-06-15 22:45:26
Subsystem: library code, the rest · Maintainers: Andrew Morton, Linus Torvalds

From: Johannes Sixt <redacted>

If an untracked text file is selected, then its contents are displayed
instead of a diff. If the file is large, then the following hint is
inserted at the top:

  * Untracked file is 14774881 bytes.
  * Showing only first 131072 bytes.

Why exactly 131072 bytes? With this patch it is 100000 bytes.

Signed-off-by: Johannes Sixt <redacted>
---
 Another bikeshed to paint. ;)

 Every now and then I stumble over this number, and I ask myself,
 why are those h4x3rs so binary?

 -- Hannes

 lib/diff.tcl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/diff.tcl b/lib/diff.tcl
index abe502d..6e08704 100644
--- a/lib/diff.tcl
+++ b/lib/diff.tcl
@@ -164,7 +164,7 @@ proc show_other_diff {path w m cont_info} {
 	# - Git won't give us the diff, there's nothing to compare to!
 	#
 	if {$m eq {_O}} {
-		set max_sz [expr {128 * 1024}]
+		set max_sz 100000
 		set type unknown
 		if {[catch {
 				set type [file type $path]
-- 
1.6.0.2.319.gffa7c
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help