[PATCH] gitweb: Add path_info tests to t/t9500-gitweb-standalone-no-errors.sh

Subsystems: the rest

DORMANTno replies

3 messages, 3 authors, 2016-06-15 · open the first message on its own page

[PATCH] gitweb: Add path_info tests to t/t9500-gitweb-standalone-no-errors.sh

From: Jakub Narebski <hidden>
Date: 2016-06-15 22:45:26

Note that those tests only that there are no errors nor warnings
from Perl; they do not check for example if gitweb doesn't use
ARRAY(0x8e3cc20) instead of correct value in links, etc.

Signed-off-by: Jakub Narebski <redacted>
---
This is the test thans to which I have dicovered errors in git_tree()
fixed in previous email. Nevertheless those two patches are unrelated,
so they are not numbered.

Those tests check _current_ situation, without $action, not
$hash_parent parameters possible in path_info.

 t/t9500-gitweb-standalone-no-errors.sh |   49 ++++++++++++++++++++++++++++++++
 1 files changed, 49 insertions(+), 0 deletions(-)
diff --git a/t/t9500-gitweb-standalone-no-errors.sh b/t/t9500-gitweb-standalone-no-errors.sh
index 07117a8..64c4cce 100755
--- a/t/t9500-gitweb-standalone-no-errors.sh
+++ b/t/t9500-gitweb-standalone-no-errors.sh
@@ -503,6 +503,55 @@ test_expect_success \
 test_debug 'cat gitweb.log'
 
 # ----------------------------------------------------------------------
+# path_info links
+test_expect_success \
+	'path_info: project' \
+	'gitweb_run "" "/.git"'
+test_debug 'cat gitweb.log'
+
+test_expect_success \
+	'path_info: project/branch' \
+	'gitweb_run "" "/.git/b"'
+test_debug 'cat gitweb.log'
+
+test_expect_success \
+	'path_info: project/branch:file' \
+	'gitweb_run "" "/.git/master:file"'
+test_debug 'cat gitweb.log'
+
+test_expect_success \
+	'path_info: project/branch:dir/' \
+	'gitweb_run "" "/.git/master:foo/"'
+test_debug 'cat gitweb.log'
+
+test_expect_success \
+	'path_info: project/branch:file (non-existent)' \
+	'gitweb_run "" "/.git/master:non-existent"'
+test_debug 'cat gitweb.log'
+
+test_expect_success \
+	'path_info: project/branch:dir/ (non-existent)' \
+	'gitweb_run "" "/.git/master:non-existent/"'
+test_debug 'cat gitweb.log'
+
+
+test_expect_success \
+	'path_info: project/branch:/file' \
+	'gitweb_run "" "/.git/master:/file"'
+test_debug 'cat gitweb.log'
+
+test_expect_success \
+	'path_info: project/:/file (implicit HEAD)' \
+	'gitweb_run "" "/.git/:/file"'
+test_debug 'cat gitweb.log'
+
+test_expect_success \
+	'path_info: project/:/ (implicit HEAD, top tree)' \
+	'gitweb_run "" "/.git/:/"'
+test_debug 'cat gitweb.log'
+
+
+# ----------------------------------------------------------------------
 # feed generation
 
 test_expect_success \

Re: [PATCH] gitweb: Add path_info tests to t/t9500-gitweb-standalone-no-errors.sh

From: Petr Baudis <hidden>
Date: 2016-06-15 22:45:26

On Thu, Oct 02, 2008 at 04:52:20PM +0200, Jakub Narebski wrote:
Note that those tests only that there are no errors nor warnings
from Perl; they do not check for example if gitweb doesn't use
ARRAY(0x8e3cc20) instead of correct value in links, etc.

Signed-off-by: Jakub Narebski <redacted>
---
This is the test thans to which I have dicovered errors in git_tree()
fixed in previous email. Nevertheless those two patches are unrelated,
so they are not numbered.

Those tests check _current_ situation, without $action, not
$hash_parent parameters possible in path_info.
I didn't test the patch but it all looks sensible.

Acked-by: Petr Baudis <redacted>

Re: [PATCH] gitweb: Add path_info tests to t/t9500-gitweb-standalone-no-errors.sh

From: Eric Raible <hidden>
Date: 2016-06-15 22:45:26

Jakub Narebski <jnareb <at> gmail.com> writes:
Note that those tests only that there are no errors nor warnings
from Perl; they do not check for example if gitweb doesn't use
ARRAY(0x8e3cc20) instead of correct value in links, etc.

Signed-off-by: Jakub Narebski <jnareb <at> gmail.com>
---
s/only that/only check that/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help