Re: [QGit] [PATCH] Modify Highlight Color at File Context View.

4 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [QGit] [PATCH] Modify Highlight Color at File Context View.

From: Marco Costalba <hidden>
Date: 2016-06-15 22:45:25

On Mon, Sep 29, 2008 at 3:27 AM, Li Frank-B20596 [off-list ref] wrote:
Marco:

         I don't get my patch by git-pull.
         There are not my patch at
http://git.kernel.org/?p=qgit/qgit4.git;a=summary.

best regards
Frank Li
________________________________
I have pushed to my local repo, I will be able to push to public repo
only this week end.

Marco

Re: [QGit] [PATCH] Modify Highlight Color at File Context View.

From: Marco Costalba <hidden>
Date: 2016-06-15 22:45:26

On Wed, Oct 1, 2008 at 8:47 AM, Marco Costalba [off-list ref] wrote:
On Mon, Sep 29, 2008 at 3:27 AM, Li Frank-B20596 [off-list ref] wrote:
quoted
Marco:

         I don't get my patch by git-pull.
         There are not my patch at
http://git.kernel.org/?p=qgit/qgit4.git;a=summary.

best regards
Frank Li
________________________________
I have pushed to my local repo, I will be able to push to public repo
only this week end.
Ok. Now is pushed to public repo.

Frank, are you sure it works? for me it does not seem to make any difference.

Marco

RE: [QGit] [PATCH] Modify Highlight Color at File Context View.

From: Li Frank-B20596 <hidden>
Date: 2016-06-15 22:45:26

 
Marco:
	
	It is difference between my patch and you applied patch. 

Git diff HEAD^
-	item->setForeground(b);
+		item->setForeground(fore);
+		item->setForeground(back);
 		item->setFont(f);

In my patch:

-		item->setForeground(b);
+		item->setForeground(fore);
+		item->setBackground(back);

It should be setBackground(back), not setForeground(back);


Best regards
Frank Li

-----Original Message-----
From: Marco Costalba [mailto:mcostalba@gmail.com] 
Sent: Saturday, October 04, 2008 2:20 PM
To: Li Frank-B20596
Cc: git@vger.kernel.org
Subject: Re: [QGit] [PATCH] Modify Highlight Color at File Context View.

On Wed, Oct 1, 2008 at 8:47 AM, Marco Costalba [off-list ref]
wrote:
On Mon, Sep 29, 2008 at 3:27 AM, Li Frank-B20596
[off-list ref] wrote:
quoted
Marco:

         I don't get my patch by git-pull.
         There are not my patch at
http://git.kernel.org/?p=qgit/qgit4.git;a=summary.

best regards
Frank Li
________________________________
I have pushed to my local repo, I will be able to push to public repo 
only this week end.
Ok. Now is pushed to public repo.

Frank, are you sure it works? for me it does not seem to make any
difference.

Marco

Re: [QGit] [PATCH] Modify Highlight Color at File Context View.

From: Marco Costalba <hidden>
Date: 2016-06-15 22:45:26

On Sat, Oct 4, 2008 at 4:32 PM, Li Frank-B20596 [off-list ref] wrote:
It should be setBackground(back), not setForeground(back);
Ahaaaa! My bad!

Sorry for this. Fix pushed.

Thanks
Marco
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help