On Mon, Sep 29, 2008 at 3:27 AM, Li Frank-B20596 [off-list ref] wrote:
Marco:
I don't get my patch by git-pull.
There are not my patch at
http://git.kernel.org/?p=qgit/qgit4.git;a=summary.
best regards
Frank Li
________________________________
I have pushed to my local repo, I will be able to push to public repo
only this week end.
Marco
On Wed, Oct 1, 2008 at 8:47 AM, Marco Costalba [off-list ref] wrote:
On Mon, Sep 29, 2008 at 3:27 AM, Li Frank-B20596 [off-list ref] wrote:
quoted
Marco:
I don't get my patch by git-pull.
There are not my patch at
http://git.kernel.org/?p=qgit/qgit4.git;a=summary.
best regards
Frank Li
________________________________
I have pushed to my local repo, I will be able to push to public repo
only this week end.
Ok. Now is pushed to public repo.
Frank, are you sure it works? for me it does not seem to make any difference.
Marco
Marco:
It is difference between my patch and you applied patch.
Git diff HEAD^
- item->setForeground(b);
+ item->setForeground(fore);
+ item->setForeground(back);
item->setFont(f);
In my patch:
- item->setForeground(b);
+ item->setForeground(fore);
+ item->setBackground(back);
It should be setBackground(back), not setForeground(back);
Best regards
Frank Li
-----Original Message-----
From: Marco Costalba [mailto:mcostalba@gmail.com]
Sent: Saturday, October 04, 2008 2:20 PM
To: Li Frank-B20596
Cc: git@vger.kernel.org
Subject: Re: [QGit] [PATCH] Modify Highlight Color at File Context View.
On Wed, Oct 1, 2008 at 8:47 AM, Marco Costalba [off-list ref]
wrote:
On Mon, Sep 29, 2008 at 3:27 AM, Li Frank-B20596
[off-list ref] wrote:
quoted
Marco:
I don't get my patch by git-pull.
There are not my patch at
http://git.kernel.org/?p=qgit/qgit4.git;a=summary.
best regards
Frank Li
________________________________
I have pushed to my local repo, I will be able to push to public repo
only this week end.
Ok. Now is pushed to public repo.
Frank, are you sure it works? for me it does not seem to make any
difference.
Marco
On Sat, Oct 4, 2008 at 4:32 PM, Li Frank-B20596 [off-list ref] wrote:
It should be setBackground(back), not setForeground(back);
Ahaaaa! My bad!
Sorry for this. Fix pushed.
Thanks
Marco