Re: [kernel.org users] [RFD] On deprecating "git-foo" for builtins

Jeff King [off-list ref] writes:

quoted

In March 2008, the sample git-hooks and git-web used git<DASH> commands.  
That was the last I looked at git until Tuesday of this week.

Yes, and some of the test scripts still have git-* in them. I think in
that respect, the git community has been very bad about eating our own
dog food.

Not at all.

For one thing, hooks do run under modified PATH, as already pointed out in
the earlier thread.

Test scripts are executed in a special environment whose GIT_EXEC_PATH
points at the top of the build tree, where all git-foo lives.

Before anybody greps in Documentation/ to make pointless noises about some
dashed-form git-foo in there when we do not talk about what the user types
but about a command as a concept in manual pages, they are left in dashed
form deliberately, partly to help manpage browsers crosslink across pages.

We could have described typographic convention,

Cf.

    http://thread.gmane.org/gmane.comp.version-control.git/86940/focus=87008

but we ended up not doing so.

On Thu, Aug 28, 2008 at 04:24:50PM -0700, Junio C Hamano wrote:

Before anybody greps in Documentation/ to make pointless noises about some
dashed-form git-foo in there when we do not talk about what the user types
but about a command as a concept in manual pages, they are left in dashed
form deliberately, partly to help manpage browsers crosslink across pages.

What is the other part? And is it really worth the confusion? Are the
gazillions cases of dashed-form git-foo in there where we DO talk about
what the user types "pointless noises" too?

(I have argued further in the other mail but somehow we seem to have
gone off the list with that subthread, hmm.)

				Petr "Pasky" Baudis

My (ahem) implied point (sorry) also was that these "hook" scripts act  
as examples of how to write git scripts in general, and some of them  
are written to me run as regular scripts.

-- Perry

On Aug 28, 2008, at 4:24 PM, Junio C Hamano wrote:

Jeff King [off-list ref] writes:

quoted

quoted

In March 2008, the sample git-hooks and git-web used git<DASH>  
commands.
That was the last I looked at git until Tuesday of this week.

Yes, and some of the test scripts still have git-* in them. I think  
in
that respect, the git community has been very bad about eating our  
own
dog food.

Not at all.

For one thing, hooks do run under modified PATH, as already pointed  
out in
the earlier thread.

Test scripts are executed in a special environment whose GIT_EXEC_PATH
points at the top of the build tree, where all git-foo lives.

Before anybody greps in Documentation/ to make pointless noises  
about some
dashed-form git-foo in there when we do not talk about what the user  
types
but about a command as a concept in manual pages, they are left in  
dashed
form deliberately, partly to help manpage browsers crosslink across  
pages.

We could have described typographic convention,

Cf.

   http://thread.gmane.org/gmane.comp.version-control.git/86940/focus=87008

but we ended up not doing so.

On Thu, Aug 28, 2008 at 04:24:50PM -0700, Junio C Hamano wrote:

Test scripts are executed in a special environment whose GIT_EXEC_PATH
points at the top of the build tree, where all git-foo lives.

I am not sure how GIT_EXEC_PATH is relevant. We put the git top-level
directory in the PATH, which is why "git-foo" works at all in the test
scripts. But the install by default does _not_ put those commands in
the PATH. So the test scripts serve as a poor example of how to use
git. The commands contained within them would not run in an ordinary git
installation.

-Peff