Re: [PATCH] Add a reference to gitk localbranc remote/branch in gittutorial

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] Add a reference to gitk localbranc remote/branch in gittutorial

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:13

Eric Raible [off-list ref] writes:
Paolo Ciarrocchi <paolo.ciarrocchi <at> gmail.com> writes:
quoted
+Alice can also use gitk to browse that Bob did:
s/that/what/ ?
quoted
+------------------------------------------------
+alice$ gitk master origin/master
+------------------------------------------------
I think that you meant:

alice$ gitk master..origin/master

I'd suggest rewording the explanation to have Alice "compare what both of
them did", not just "browse what Bob did".

And for that purpose, I think the original form used by Paolo's patch is
the most appropriate here in an early part of the tutorial, as it teaches
how to view full histories leading to the tips of these two branches.

Earlier in the tutorial sequence we teach "gitk" without any parameter to
view the history of the current branch, and here the user learns one new
thing, to view more than just the current branch.

Limiting the output with "..origin/master" (or "...origin/master") can be
taught after demonstrating this most basic form.

Re: [PATCH] Add a reference to gitk localbranc remote/branch in gittutorial

From: Paolo Ciarrocchi <hidden>
Date: 2016-06-15 22:45:13

On 8/25/08, Junio C Hamano [off-list ref] wrote:
Eric Raible [off-list ref] writes:
quoted
Paolo Ciarrocchi <paolo.ciarrocchi <at> gmail.com> writes:
quoted
+Alice can also use gitk to browse that Bob did:
s/that/what/ ?
quoted
+------------------------------------------------
+alice$ gitk master origin/master
+------------------------------------------------
I think that you meant:

alice$ gitk master..origin/master

I'd suggest rewording the explanation to have Alice "compare what both of
them did", not just "browse what Bob did".
yes, what i wrote was unclear. I managed to confuse myself too :-)
And for that purpose, I think the original form used by Paolo's patch is
the most appropriate here in an early part of the tutorial, as it teaches
how to view full histories leading to the tips of these two branches.
well, it might be a good idea to mention both.

do you think we should add a note about git log --graph as well?
Earlier in the tutorial sequence we teach "gitk" without any parameter to
view the history of the current branch, and here the user learns one new
thing, to view more than just the current branch.
i think we should use the nice gitk output in other sections of the
document as well, i'll send some more patches.
Limiting the output with "..origin/master" (or "...origin/master") can be
taught after demonstrating this most basic form.

what wording would you use to clearly explain the difference between
..origin/master and ...origin/master ?

anyway, thanks for the commentr. I'll send a new patch in 24 hours.

ciao,
-- 
Paolo
http://paolo.ciarrocchi.googlepages.com/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help