[PATCH] git-p4: Fix one-liner in p4_write_pipe function.

Subsystems: the rest

STALE3712d

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

[PATCH] git-p4: Fix one-liner in p4_write_pipe function.

From: Tor Arvid Lund <hidden>
Date: 2016-06-15 22:45:12

The function built a p4 command string via the p4_build_cmd function, but
ignored the result.
---
 contrib/fast-import/git-p4 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index f9865b4..46136d4 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -76,7 +76,7 @@ def write_pipe(c, str):
 
 def p4_write_pipe(c, str):
     real_cmd = p4_build_cmd(c)
-    return write_pipe(c, str)
+    return write_pipe(real_cmd, str)
 
 def read_pipe(c, ignore_error=False):
     if verbose:
-- 
1.6.0.GIT

Re: [PATCH] git-p4: Fix one-liner in p4_write_pipe function.

From: Anand Kumria <hidden>
Date: 2016-06-15 22:45:13

On Thu, 21 Aug 2008 23:11:40 +0200, Tor Arvid Lund wrote:
The function built a p4 command string via the p4_build_cmd function,
but ignored the result.
Opps - thanks for catching this.

Anand
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help