[EGIT PATCH] Enable diff=java for all *.java source files

Subsystems: the rest

DORMANTno replies

3 messages, 2 authors, 2016-06-15 · open the first message on its own page

[EGIT PATCH] Enable diff=java for all *.java source files

From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:45:10

This (usually) gets more reasonable function headers to
appear in the header line for a diff hunk.  Its slightly
better than the default C rules.

Signed-off-by: Shawn O. Pearce <redacted>
---
 .gitattributes |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
 create mode 100644 .gitattributes
diff --git a/.gitattributes b/.gitattributes
new file mode 100644
index 0000000..f57840b
--- /dev/null
+++ b/.gitattributes
@@ -0,0 +1 @@
+*.java diff=java
-- 
1.6.0.rc3.250.g8dd0

Re: [EGIT PATCH] Enable diff=java for all *.java source files

From: Robin Rosenberg <hidden>
Date: 2016-06-15 22:45:10

fredagen den 15 augusti 2008 17.40.22 skrev Shawn O. Pearce:
quoted hunk
This (usually) gets more reasonable function headers to
appear in the header line for a diff hunk.  Its slightly
better than the default C rules.

Signed-off-by: Shawn O. Pearce <redacted>
---
 .gitattributes |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
 create mode 100644 .gitattributes
diff --git a/.gitattributes b/.gitattributes
new file mode 100644
index 0000000..f57840b
--- /dev/null
+++ b/.gitattributes
@@ -0,0 +1 @@
+*.java diff=java
Is there any reason this isn't the default in git?

-- robin

Re: [EGIT PATCH] Enable diff=java for all *.java source files

From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:45:10

Robin Rosenberg [off-list ref] wrote:
quoted
diff --git a/.gitattributes b/.gitattributes
new file mode 100644
index 0000000..f57840b
--- /dev/null
+++ b/.gitattributes
@@ -0,0 +1 @@
+*.java diff=java
Is there any reason this isn't the default in git?
Because uh.  Nobody submitted a patch to make it the default?

It does seem like it would be a good idea to make it the default.
Its unlikely the C function header pattern is ever going to produce a
more reasonable hunk header for a *.java file than the Java pattern.

-- 
Shawn.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help