DORMANTno replies

[JGIT PATCH] Paper bag fix 'jgit glog' handling of commit-ish arguments

From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:45:09
Subsystem: the rest · Maintainer: Linus Torvalds

When we parsed these arguments into RevCommit instances they were
done against the wrong RevWalk instance.  We parsed them into a
generic RevWalk which has no plotting support, so the objects do
not have the extra fields used by the plotting code.  We need to
lookup the commit from the PlotRevWalk and use those instances.

One of the calls (markStart) failed to use the secondary RevWalk
instance, resulting in a ClassCastException during plotting.

Signed-off-by: Shawn O. Pearce <redacted>
---
 .../org/spearce/jgit/pgm/RevWalkTextBuiltin.java   |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RevWalkTextBuiltin.java b/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RevWalkTextBuiltin.java
index 97fe7a4..338af40 100644
--- a/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RevWalkTextBuiltin.java
+++ b/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RevWalkTextBuiltin.java
@@ -152,7 +152,7 @@ abstract class RevWalkTextBuiltin extends TextBuiltin {
 			if (c.has(RevFlag.UNINTERESTING))
 				walk.markUninteresting(real);
 			else
-				walk.markStart(c);
+				walk.markStart(real);
 		}
 
 		final long start = System.currentTimeMillis();
-- 
1.6.0.rc3.250.g8dd0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help