Petr Baudis [off-list ref] writes:
The post-update hook, which is required to be enabled in order for
the repository to be accessible over HTTP, is not enabled by
chmod a+x anymore, but instead by dropping the .sample suffix.
Thanks for attention to the details.
This patch emphasizes this change in the release notes (since
I believe this is rather noticeable backwards-incompatible change).
Anybody who tries to chmod an nonexisting file would notice, so I
personally think you are making a mountain out of a molehill.
Nevertheless, mentioning it in the release notes would be a good finishing
touch.
+The standard way of making repositories friendly to dumb protocols
+(i.e. HTTP) changed: instead of making hooks/post-update executable,
+hooks/post-update.sample is to be moved to hooks/post-update.
I'm actually not very happy with the above wording that makes it sound as
if any of the samples are part of any "standard way".
The only standard thing is to make sure update-server-info runs. You do
not have to start from the sample hook to do so, even though it may be one
of the easiest ways.
The rest of the patches look good, but have you actually made sure
AsciiDoc markups are correct (I am not complaining, just asking, as I
haven't)?
On Mon, Aug 11, 2008 at 03:57:36PM -0700, Junio C Hamano wrote:
Petr Baudis [off-list ref] writes:
quoted
This patch emphasizes this change in the release notes (since
I believe this is rather noticeable backwards-incompatible change).
Anybody who tries to chmod an nonexisting file would notice, so I
personally think you are making a mountain out of a molehill.
Nevertheless, mentioning it in the release notes would be a good finishing
touch.
Well, my only point is that you might want to know that you have to
modify your scripts _before_ they break.
quoted
+The standard way of making repositories friendly to dumb protocols
+(i.e. HTTP) changed: instead of making hooks/post-update executable,
+hooks/post-update.sample is to be moved to hooks/post-update.
I'm actually not very happy with the above wording that makes it sound as
if any of the samples are part of any "standard way".
The only standard thing is to make sure update-server-info runs. You do
not have to start from the sample hook to do so, even though it may be one
of the easiest ways.
Then the question is what is "standard" defined as, and why shouldn't
this be the standard way? This is how our user documentation (both the
User Manual and the Git Core Tutorial) teaches the users to do it.
The rest of the patches look good, but have you actually made sure
AsciiDoc markups are correct (I am not complaining, just asking, as I
haven't)?
I haven't - actually, for various technical reasons, I don't even have
AsciiDoc installed on my notebook right now. I plan to get around
to investigate the problem, but didn't yet and I didn't want to hold
this off.
--
Petr "Pasky" Baudis
The next generation of interesting software will be done
on the Macintosh, not the IBM PC. -- Bill Gates