Re: [PATCH 2/3] Teach git diff-tree --stdin to diff trees

Karl Hasselström [off-list ref] writes:

On 2008-08-08 14:22:45 -0700, Junio C Hamano wrote:
...

quoted

But the following two sentences are a bit confusing, especially it
is unclear what "This" refers to in the last sentence.

quoted

When diffing trees, the -m, -s, -v, --pretty, --abbrev-commit,
--encoding, --no-commit-id, -c, --cc, and --always options are
ignored, since they do not apply to trees. This is the same
behavior you get when specifying two trees on the command line
instead of with --stdin.

Perhaps swap the sentences in the log message like this?

  When feeding trees on the command line, you can give exactly two
  trees, not three nor one; --stdin now supports this "two tree"
  form on its input, in addition to accepting lines with one or more
  commits.

  When diffing trees (either specified on the command line or from
  the standard input), the -m, -s, -v, --pretty, --abbrev-commit,
  --encoding, --no-commit-id, -c, --cc, and --always options are
  ignored, since they do not apply to trees.

Will do. Thanks.

Thinking about it a bit more, -m, -c and --cc are not about commits at
all.  Your excuse not to support them is because these three are about
diffing more than two trees (and I'd say that is still a good rationale).

On 2008-08-09 13:07:50 -0700, Junio C Hamano wrote:

Thinking about it a bit more, -m, -c and --cc are not about commits
at all. Your excuse not to support them is because these three are
about diffing more than two trees (and I'd say that is still a good
rationale).

Indeed (but only because that mode is not supported on the command
line). Would you like a commit message with a revised excuse?

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle