Re: [PATCH] tests: use $TEST_DIRECTORY to refer to the t/ directory

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH] tests: use $TEST_DIRECTORY to refer to the t/ directory

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:07

Johannes Schindelin [off-list ref] writes:
Frankly, I do not have the time.  It is not only about looking what you 
changed, but also what you did not change.
That's Ok.  You are not (and you shouldn't be) the only person who is
capable of reviewing and helping the development process ;-)

Hint, hint...

Re: [PATCH] tests: use $TEST_DIRECTORY to refer to the t/ directory

From: Stephan Beyer <hidden>
Date: 2016-06-15 22:45:07

Hi,

Junio C Hamano wrote:
Hint, hint...
I've taken only a short look, and:

	$ GIT_TEST_HTTPD=1 ./t5540-http-push.sh
	* skipping test, web server setup failed
	* passed all 0 test(s)

after the following change, it became:

	$ GIT_TEST_HTTPD=1 ./t5540-http-push.sh
	*   ok 1: setup remote repository
	*   ok 2: clone remote repository
	*   still broken 3: push to remote repository
	*   still broken 4: create and delete remote branch
	* still have 2 known breakage(s)
	* passed all remaining 2 test(s)

Regards.

--snip--
diff --git a/t/lib-httpd.sh b/t/lib-httpd.sh
index dc473df..6ac312b 100644
--- a/t/lib-httpd.sh
+++ b/t/lib-httpd.sh
@@ -14,7 +14,7 @@ fi
 LIB_HTTPD_PATH=${LIB_HTTPD_PATH-'/usr/sbin/apache2'}
 LIB_HTTPD_PORT=${LIB_HTTPD_PORT-'8111'}
 
-TEST_PATH="$PWD"/../lib-httpd
+TEST_PATH="$TEST_DIRECTORY"/lib-httpd
 HTTPD_ROOT_PATH="$PWD"/httpd
 HTTPD_DOCUMENT_ROOT_PATH=$HTTPD_ROOT_PATH/www
 
-- 
Stephan Beyer <s-beyer@gmx.net>, PGP 0x6EDDD207FCC5040F
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help