Re: git diff/log --check exitcode and PAGER environment variable

"Peter Valdemar Mørch (Lists)"  [off-list ref] writes:

There is this old thread:
"[PATCH 1/5] "diff --check" should affect exit status"
http://thread.gmane.org/gmane.comp.version-control.git/68145/focus=68148
which seemed not to reach a conclusion.

Conclusion was (1) if you really care about the exit code, do not use
pager; (2) after 1.6.0 we will swap the child/parent between git and pager
to expose exit code from us, but not before.

Or am I mistaken?

Junio C Hamano gitster-at-pobox.com |Lists| wrote:

quoted

There is this old thread:
"[PATCH 1/5] "diff --check" should affect exit status"
http://thread.gmane.org/gmane.comp.version-control.git/68145/focus=68148
which seemed not to reach a conclusion.

Conclusion was (1) if you really care about the exit code, do not use
pager; (2) after 1.6.0 we will swap the child/parent between git and pager
to expose exit code from us, but not before.

Or am I mistaken?

Perhaps a more correct statement on my part would have been that I 
couldn't find the conclusion. :-)

It ended with Junio C Hamano saying:

Heh, I am about to push out fixed-up results, so it might save both of
us some time if you looked at it first and then complained on my
screwups.

I wasn't subscribed to the list back then and couldn't follow beyond 
that thread in GMane.

Regardless of what happened or not back then, the current documentation 
does not match the current code. Not for git-diff, and certainly not for 
git-log.

Or am I mistaken?

I didn't see a reference in that thread to post 1.6.0 changes or to 
child/parent relationships, but if this is known and planned for 
post-1.6.0, then cool: I'll get on with my life and let you get on with 
yours!

Peter
-- 
Peter Valdemar Mørch
http://www.morch.com

On Fri, Aug 08, 2008 at 02:44:37AM -0700, Junio C Hamano wrote:

"Peter Valdemar Mørch (Lists)"  [off-list ref] writes:

quoted

There is this old thread:
"[PATCH 1/5] "diff --check" should affect exit status"
http://thread.gmane.org/gmane.comp.version-control.git/68145/focus=68148
which seemed not to reach a conclusion.

Conclusion was (1) if you really care about the exit code, do not use
pager; (2) after 1.6.0 we will swap the child/parent between git and pager
to expose exit code from us, but not before.

Or am I mistaken?

Yes, all of his testing with "git diff" is hampered by the pager hiding
the exit code. And that is dealt with by the patches in next (and I
tested his examples with 'next', and they work fine).

But that still leaves the part about "git log" not changing its exit
code. I don't think it has ever been designed to, and I'm not even sure
what the semantics would be (exit code != 0 if any logged commit has a
whitespace problem? That seems the most logical, and it might be useful
for limited ranges).

-Peff

On Fri, Aug 08, 2008 at 09:17:59AM -0400, Jeff King wrote:

Yes, all of his testing with "git diff" is hampered by the pager hiding
the exit code. And that is dealt with by the patches in next (and I
tested his examples with 'next', and they work fine).

But that still leaves the part about "git log" not changing its exit
code. I don't think it has ever been designed to, and I'm not even sure
what the semantics would be (exit code != 0 if any logged commit has a
whitespace problem? That seems the most logical, and it might be useful
for limited ranges).

...and then after writing this I realized that all of this was dealt
with later in the thread. Sorry for the noise.

-Peff