Re: [PATCH 3/3] Enable parallel tests

Johannes Schindelin [off-list ref] writes:

On multiprocessor machines, or with I/O heavy tests (that leave the
CPU waiting a lot), it makes sense to parallelize the tests.

I was actually thinking about doing this eventually.  Thanks for beating
me to it.

Parallel mode also triggers removal of the trash directory in the test
itself if everything went fine, so that the trash directories do not
pile up only to be removed at the very end.

I think making the tests remove their own mess makes sense regardless.

I have to wonder why you would want to make this change conditional on
MAKEFLAGS.  I was envisioning that parallel tests would run in "trash
directory/$(basename $0)" or something.

Are there downsides of doing this change unconditionally?

 clean:
-	$(RM) -r 'trash directory' test-results
+	$(RM) -rf 'trash directory' test-results

This is not needed, I think, as RM is defined with -f already.

Hi,

On Thu, 7 Aug 2008, Junio C Hamano wrote:

Johannes Schindelin [off-list ref] writes:

quoted

Parallel mode also triggers removal of the trash directory in the test 
itself if everything went fine, so that the trash directories do not 
pile up only to be removed at the very end.

I think making the tests remove their own mess makes sense regardless.

When I add tests, I first run the appropriate t/t*.sh, then expect what is 
in trash directory, then extend the test.  So at least I need an option to 
keep the directory.

quoted

 clean:
-	$(RM) -r 'trash directory' test-results
+	$(RM) -rf 'trash directory' test-results

This is not needed, I think, as RM is defined with -f already.

Okay, thanks.

Ciao,
Dscho