DORMANTno replies

[PATCH] Make non-static functions, that may be static, static

From: Stephan Beyer <hidden>
Date: 2016-06-15 22:45:00
Subsystem: the rest · Maintainer: Linus Torvalds

Signed-off-by: Stephan Beyer <redacted>
---

Or are there any reasons against that? :)

 builtin-commit.c       |    2 +-
 builtin-config.c       |    2 +-
 builtin-for-each-ref.c |    2 +-
 builtin-merge.c        |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/builtin-commit.c b/builtin-commit.c
index 97e64de..9d7100c 100644
--- a/builtin-commit.c
+++ b/builtin-commit.c
@@ -877,7 +877,7 @@ static void print_summary(const char *prefix, const unsigned char *sha1)
 	}
 }
 
-int git_commit_config(const char *k, const char *v, void *cb)
+static int git_commit_config(const char *k, const char *v, void *cb)
 {
 	if (!strcmp(k, "commit.template"))
 		return git_config_string(&template_file, k, v);
diff --git a/builtin-config.c b/builtin-config.c
index 0cf191a..91fdc49 100644
--- a/builtin-config.c
+++ b/builtin-config.c
@@ -145,7 +145,7 @@ free_strings:
 	return ret;
 }
 
-char *normalize_value(const char *key, const char *value)
+static char *normalize_value(const char *key, const char *value)
 {
 	char *normalized;
 
diff --git a/builtin-for-each-ref.c b/builtin-for-each-ref.c
index 76282ad..445039e 100644
--- a/builtin-for-each-ref.c
+++ b/builtin-for-each-ref.c
@@ -809,7 +809,7 @@ static struct ref_sort *default_sort(void)
 	return sort;
 }
 
-int opt_parse_sort(const struct option *opt, const char *arg, int unset)
+static int opt_parse_sort(const struct option *opt, const char *arg, int unset)
 {
 	struct ref_sort **sort_tail = opt->value;
 	struct ref_sort *s;
diff --git a/builtin-merge.c b/builtin-merge.c
index 8825dcf..e78fa18 100644
--- a/builtin-merge.c
+++ b/builtin-merge.c
@@ -431,7 +431,7 @@ static void merge_name(const char *remote, struct strbuf *msg)
 		sha1_to_hex(remote_head->sha1), remote);
 }
 
-int git_merge_config(const char *k, const char *v, void *cb)
+static int git_merge_config(const char *k, const char *v, void *cb)
 {
 	if (branch && !prefixcmp(k, "branch.") &&
 		!prefixcmp(k + 7, branch) &&
-- 
1.6.0.rc0.102.ga1791
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help