Re: [PATCH 02/12] git-grep: support --no-external-grep

2 messages, 1 author, 2016-06-15 · open the first message on its own page

Re: [PATCH 02/12] git-grep: support --no-external-grep

From: Petr Baudis <hidden>
Date: 2016-06-15 22:45:00

  Hi,

  the patches 2, 3, 8 and 10 of your series introduce config options,
commandline switches and environment variables that are not documented
anywhere - can you please include documentation updates in your patch
series as well? It might be worth it to find some suitable place in the
documentation where to explain the concept itself; it took me quite
sometime before I actually realized (I think) what are your patches
about. (Which is also why is it useful to write cover letters for
patch series.)

-- 
				Petr "Pasky" Baudis
As in certain cults it is possible to kill a process if you know
its true name.  -- Ken Thompson and Dennis M. Ritchie

Re: [PATCH 02/12] git-grep: support --no-external-grep

From: Petr Baudis <hidden>
Date: 2016-06-15 22:45:00

  Hi!

On Wed, Jul 23, 2008 at 09:01:30PM +0200, Petr Baudis wrote:
(Which is also why is it useful to write cover letters for
patch series.)
  sorry, I did not notice the cover letter, already separated from the
rest by a sprouting thread. Which is also why it is useful to thread up
all the patches. ;-)

				Petr "Pasky" Baudis
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help