Re: [PATCH 02/12] git-grep: support --no-external-grep
From: Petr Baudis <hidden>
Date: 2016-06-15 22:45:00
Hi, the patches 2, 3, 8 and 10 of your series introduce config options, commandline switches and environment variables that are not documented anywhere - can you please include documentation updates in your patch series as well? It might be worth it to find some suitable place in the documentation where to explain the concept itself; it took me quite sometime before I actually realized (I think) what are your patches about. (Which is also why is it useful to write cover letters for patch series.) -- Petr "Pasky" Baudis As in certain cults it is possible to kill a process if you know its true name. -- Ken Thompson and Dennis M. Ritchie