[PATCH] perl/Makefile: update NO_PERL_MAKEMAKER section

Subsystems: the rest

STALE3707d

3 messages, 2 authors, 2016-06-15 · open the first message on its own page

[PATCH] perl/Makefile: update NO_PERL_MAKEMAKER section

From: Brandon Casey <hidden>
Date: 2016-06-15 22:44:59

The perl modules must be copied to blib/lib so they are available for
testing.

Signed-off-by: Brandon Casey <redacted>
---
 perl/Makefile |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/perl/Makefile b/perl/Makefile
index 5e079ad..2b0d3d5 100644
--- a/perl/Makefile
+++ b/perl/Makefile
@@ -22,8 +22,11 @@ clean:
 ifdef NO_PERL_MAKEMAKER
 instdir_SQ = $(subst ','\'',$(prefix)/lib)
 $(makfile): ../GIT-CFLAGS Makefile
-	echo all: > $@
-	echo '	:' >> $@
+	echo all: private-Error.pm Git.pm > $@
+	echo '	mkdir -p blib/lib' >> $@
+	echo '	$(RM) blib/lib/Git.pm; cp Git.pm blib/lib/' >> $@
+	echo '	$(RM) blib/lib/Error.pm; \
+	cp private-Error.pm blib/lib/Error.pm' >> $@
 	echo install: >> $@
 	echo '	mkdir -p $(instdir_SQ)' >> $@
 	echo '	$(RM) $(instdir_SQ)/Git.pm; cp Git.pm $(instdir_SQ)' >> $@
-- 
1.6.0.rc0.38.g8b8fb7

Re: [PATCH] perl/Makefile: update NO_PERL_MAKEMAKER section

From: Petr Baudis <hidden>
Date: 2016-06-15 22:44:59

On Tue, Jul 22, 2008 at 04:15:41PM -0500, Brandon Casey wrote:
The perl modules must be copied to blib/lib so they are available for
testing.

Signed-off-by: Brandon Casey <redacted>
I don't understand why do you need to do this; perl.mak should do this
on its own during project-wide make all. What Perl version are you using?
How does the pm_to_blib target look like?

	pm_to_blib : $(TO_INST_PM)
        $(NOECHO) $(ABSPERLRUN) -MExtUtils::Install -e 'pm_to_blib({@ARGV}, '\''$(INST_LIB)/auto'\'', '\''$(PM_FILTER)'\'')' -- \
          Git.pm $(INST_LIBDIR)/Git.pm
        $(NOECHO) $(TOUCH) pm_to_blib

here. Is your INST_LIB = blib/lib and INST_LIBDIR = $(INST_LIB)?

-- 
				Petr "Pasky" Baudis
As in certain cults it is possible to kill a process if you know
its true name.  -- Ken Thompson and Dennis M. Ritchie

Re: [PATCH] perl/Makefile: update NO_PERL_MAKEMAKER section

From: Brandon Casey <hidden>
Date: 2016-06-15 22:45:00

Petr Baudis wrote:
On Tue, Jul 22, 2008 at 04:15:41PM -0500, Brandon Casey wrote:
quoted
The perl modules must be copied to blib/lib so they are available for
testing.

Signed-off-by: Brandon Casey <redacted>
I don't understand why do you need to do this; perl.mak should do this
on its own during project-wide make all.
perl.mak is auto-generated by one of two methods in perl/Makefile. This
patch modifies the 'NO_PERL_MAKEMAKER' section. Currently 'make all', when
NO_PERL_MAKEMAKER is set, does nothing, and looks like:

  $ cat perl.mak
  all:
	:
  install:
	mkdir -p ...

With this patch it looks like:

  $ cat perl.mak
  all: private-Error.pm Git.pm
          mkdir -p blib/lib
          rm -f blib/lib/Git.pm; cp Git.pm blib/lib/
          rm -f blib/lib/Error.pm;  cp private-Error.pm blib/lib/Error.pm
  install:
          mkdir -p ...

-brandon
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help