Are C++ contributions welcome?

I think Git is a really good project and I would like to contribute to it.
I have been having a look to the source and I have realized on that all
code is C(well and perl for some scripts and so..). I know that C++ code
was not welcome sometime ago, but I don't know if this have changed.

I don't feel comfortable programing in C and I prefer C++ only because I
have more experience using this one. May I contribute to this project in
that language?.

Thanks a lot.

Hi,

On Fri, 20 Jun 2008, jose maria gomez vergara wrote:

I know that C++ code was not welcome sometime ago, but I don't know if 
this have changed.

You probably mean

	http://article.gmane.org/gmane.comp.version-control.git/58929

but I cannot help but wonder why anything should have changed since then.

I don't feel comfortable programing in C and I prefer C++ only because I 
have more experience using this one. May I contribute to this project in 
that language?.

Of course, you can try to contribute something in C++, but that will 
probably only trigger someone rewriting your stuff in (portable) C and 
take all your credit.

Heck, I might do it myself ;-)

Ciao,
Dscho

Jose Maria Gomez Vergara [off-list ref] writes:

I think Git is a really good project and I would like to contribute to it.
I have been having a look to the source and I have realized on that all
code is C (well and Perl for some scripts and so..). I know that C++ code
was not welcome sometime ago, but I don't know if this have changed.

I don't feel comfortable programing in C and I prefer C++ only because I
have more experience using this one. May I contribute to this project in
that language?.

I don't think that C++ would get accepted because it would introduce
another dependency; if not runtime dependency (libstdc++), then build
requirement (C++ compiler).

And I think it doesn't bring much: git is not some GUI application
where OOP works best; it is 'close to the metal' (performance), where
I think C works best.

-- 
Jakub Narebski
Poland
ShadeHawk on #git

On Fri, Jun 20, 2008 at 2:23 PM, jose maria gomez vergara
[off-list ref] wrote:

I don't feel comfortable programing in C and I prefer C++ only because I
have more experience using this one. May I contribute to this project in
that language?.

Any programmer can learn a new language as long as they have enough
programming skills; it's not the language you are proficient in, it is
the programming you are proficient in. If you would like to contribute
to git, consider polishing up your C, really it is not all that hard
;). The main thing you will probably stumble into is the lack of
std::string, but there are plenty examples in the git codebase to
learn how git handles string.

-- 
Cheers,

Sverre Rabbelier

To be honest, I like a lot projects made in C. I have been working with Qt and 
with Gtk and I must say that it is easy for me to understand Gtk that is in C 
than Qt that is in C++. Something I feel like if C++ design do unnecessary 
abstration. The thing is that due to my job, I am more familiar with C++ 
since the project in which I work at my job is a really big monster that 
seems to be easier to manage using an a litter high level language as C++ 
instead C.

I would like to learn more C, but sometime I think I should focus in one 
language and learn as much as possible about it.

Sometime ago I had to decide between C and C++. Looking around my city, it was 
easy to find a good job working for a big mega-application that for a small 
system application. It doesn't mean I like more working in high-level but C++ 
seems to have the best of both worlds. 

I will try to do things in C... 

Btw, more than strings I miss STL containers and algorithmits, but, if I want 
to join to contribute I know I must adapt myself to the rules. So, i will try 
to do thing in C.

Thanks

On Friday 20 June 2008 17:30:31 Sverre Rabbelier wrote:

On Fri, Jun 20, 2008 at 2:23 PM, jose maria gomez vergara

[off-list ref] wrote:

quoted

I don't feel comfortable programing in C and I prefer C++ only because I
have more experience using this one. May I contribute to this project in
that language?.

Any programmer can learn a new language as long as they have enough
programming skills; it's not the language you are proficient in, it is
the programming you are proficient in. If you would like to contribute
to git, consider polishing up your C, really it is not all that hard
;). The main thing you will probably stumble into is the lack of
std::string, but there are plenty examples in the git codebase to
learn how git handles string.

On Fri, Jun 20, 2008 at 9:03 AM, Johannes Schindelin
[off-list ref] wrote:

quoted

I don't feel comfortable programing in C and I prefer C++ only because I
have more experience using this one. May I contribute to this project in
that language?.

if you have UI/Win32 experience, a good friendly UI for newcomers to
GIT is something we are lacking. Johannes got started with git-cheetah
a while ago, and there is a similar project called TortoiseHg, either
might be a good starting point.

As Jakub noted, C++ is a reasonably good fit for UIs, and we are
lacking those. We have a fantastic team of people doing C work on the
core of git, and noone on GUIs. So I'd say yes, C++/UI help is
something we need 'round here :-)

cheers,



m
-- 
 martin.langhoff@gmail.com
 martin@laptop.org -- School Server Architect
 - ask interesting questions
 - don't get distracted with shiny stuff - working code first
 - http://wiki.laptop.org/go/User:Martinlanghoff

Good that is a really good news because I really like doing front-ends and GUI 
applications. I will take care of this.

On Friday 20 June 2008 17:59:09 Martin Langhoff wrote:

On Fri, Jun 20, 2008 at 9:03 AM, Johannes Schindelin

[off-list ref] wrote:

quoted

quoted

I don't feel comfortable programing in C and I prefer C++ only because I
have more experience using this one. May I contribute to this project in
that language?.

if you have UI/Win32 experience, a good friendly UI for newcomers to
GIT is something we are lacking. Johannes got started with git-cheetah
a while ago, and there is a similar project called TortoiseHg, either
might be a good starting point.

As Jakub noted, C++ is a reasonably good fit for UIs, and we are
lacking those. We have a fantastic team of people doing C work on the
core of git, and noone on GUIs. So I'd say yes, C++/UI help is
something we need 'round here :-)

cheers,



m

Before starting, do you have any preference for Qt or Gtk in Git. I feel quite 
confortable with both of them.

Qt . C++ GPL
Gtk+. C - LGPL

The quality is good for both of them

On Friday 20 June 2008 18:11:01 Jose María Gómez Vergara wrote:

Good that is a really good news because I really like doing front-ends and
GUI applications. I will take care of this.

On Friday 20 June 2008 17:59:09 Martin Langhoff wrote:

quoted

On Fri, Jun 20, 2008 at 9:03 AM, Johannes Schindelin

[off-list ref] wrote:

quoted

quoted

I don't feel comfortable programing in C and I prefer C++ only because
I have more experience using this one. May I contribute to this
project in that language?.

if you have UI/Win32 experience, a good friendly UI for newcomers to
GIT is something we are lacking. Johannes got started with git-cheetah
a while ago, and there is a similar project called TortoiseHg, either
might be a good starting point.

As Jakub noted, C++ is a reasonably good fit for UIs, and we are
lacking those. We have a fantastic team of people doing C work on the
core of git, and noone on GUIs. So I'd say yes, C++/UI help is
something we need 'round here :-)

cheers,



m

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Jose María Gómez Vergara [off-list ref] writes:

Before starting, do you have any preference for Qt or Gtk in Git. I feel quite 
confortable with both of them.

Qt . C++ GPL
Gtk+. C - LGPL

The quality is good for both of them

Please take a look at
<URL:http://developer.imendio.com/projects/giggle>.  It might be
worthwhile not to start from scratch here.

-- 
David Kastrup

On Fri, 2008-06-20 at 18:20 +0200, Jose María Gómez Vergara wrote:

Before starting, do you have any preference for Qt or Gtk in Git. I feel quite 
confortable with both of them.

Qt . C++ GPL
Gtk+. C - LGPL

If you think about using one of those 2 you might also want to take a
look at 
qgit - http://sourceforge.net/projects/qgit/ (qt)
and
giggle - http://developer.imendio.com/projects/giggle/ (gtk)

Not sure if those toolkits can for used to produce a TortoiseGit.

best regards,
Ray

Martin Langhoff wrote:

if you have UI/Win32 experience, a good friendly UI for newcomers to
GIT is something we are lacking.
  

My assessment of git-cola (formerly ugit) makes me wonder if that
statement is still true.  It doesn't have explorer integration,
and the install is tedious on windows.  But since it uses Qt4
it's purty enough for Windows users and it uses porcelain
commands so it doesn't require plumbing knowledge.

The Windows users that I've shown git cola are universally
excited to try it.  And my dogfood'ing on Linux has been going
well.

FWIW,
Barry Roberts

look nice

On Friday 20 June 2008 18:29:09 David Kastrup wrote:

Jose María Gómez Vergara [off-list ref] writes:

quoted

Before starting, do you have any preference for Qt or Gtk in Git. I feel
quite confortable with both of them.

Qt . C++ GPL
Gtk+. C - LGPL

The quality is good for both of them

Please take a look at
<URL:http://developer.imendio.com/projects/giggle>.  It might be
worthwhile not to start from scratch here.

Jose María Gómez Vergara [off-list ref] writes:

To be honest, I like a lot projects made in C. I have been working
with Qt and with Gtk and I must say that it is easy for me to
understand Gtk that is in C than Qt that is in C++. Something I feel
like if C++ design do unnecessary abstration. The thing is that due to
my job, I am more familiar with C++ since the project in which I work
at my job is a really big monster that seems to be easier to manage
using an a litter high level language as C++ instead C.

I would like to learn more C, but sometime I think I should focus in
one language and learn as much as possible about it.

This is sort of like discussing the most suitable alphabet for writing
poetry.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum