Re: Incorrect default for git stash?

4 messages, 3 authors, 2016-06-15 · open the first message on its own page

Re: Incorrect default for git stash?

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:47

Eric Raible [off-list ref] writes:
Does it bother anyone else that the default for
git stash is inconsistent with branch & tag?

git branch -> list branches
git tag    -> list tags
git stash  -> create a stash

I understand that branches & tags must explicitly named
and that stashes are by default automatically named.

But wouldn't it be less surprising to me if the default
was 'list' instead of 'save'?

- Eric
Read the whole thread:

http://thread.gmane.org/gmane.comp.version-control.git/63566/focus=63784

Re: Incorrect default for git stash?

From: Eric Raible <hidden>
Date: 2016-06-15 22:44:47

Junio C Hamano <gitster <at> pobox.com> writes:
 
Read the whole thread:

http://thread.gmane.org/gmane.comp.version-control.git/63566/focus=63784
I'm glad to know that that was already hashed out, even if it
didn't end up the way I would have decided.

Thanks for the pointer.

Re: Incorrect default for git stash?

From: しらいしななこ <hidden>
Date: 2016-06-15 22:44:47

Quoting Eric Raible [off-list ref]:
Junio C Hamano <gitster <at> pobox.com> writes:
 
quoted
Read the whole thread:

http://thread.gmane.org/gmane.comp.version-control.git/63566/focus=63784
I'm glad to know that that was already hashed out, even if it
didn't end up the way I would have decided.
Then I suspect you did not read the whole thread, as we have not "ended up"
in anywhere yet.

In particular, in

  http://thread.gmane.org/gmane.comp.version-control.git/63566/focus=63781

Junio maps out the next steps for people, who would want the behavior of
the command changed, to take.  None of these follow-up steps have been
taken by people who wanted to change the behavior of the command.

I can well imagine an alternative to make the command "list" by default
when stash.defaultsave is set to false, and actually suggested it earlier
with a patch, but I think the list consensus was negative.

  http://thread.gmane.org/gmane.comp.version-control.git/68539/focus=69045

-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/

----------------------------------------------------------------------
Get a free email address with REAL anti-spam protection.
http://www.bluebottle.com/tag/1

Re: Incorrect default for git stash?

From: Eric Raible <hidden>
Date: 2016-06-15 22:44:47

しらいしななこ <nanako3 <at> bluebottle.com> writes:
Then I suspect you did not read the whole thread, as we have not "ended up"
in anywhere yet.
You're right, of course.

I was hasty in my gmail, and was referring to
http://article.gmane.org/gmane.comp.version-control.git/85337
when I made that comment.

Anyway, I don't care enough either, especially since Junio
claims to be "quietly rewriting git-stash in C".

- Eric
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help