Boyd Lynn Gerber [off-list ref] writes:
This was from my own copy of the master archive. It is my proposal. I
thought you had to get an OK from this list before you do a push to the
main archive.
You won't do a push, the maintainer will apply the patch if it seems
OK.
What am I missing?
The format used to send patches. git format-patch and git send-email
would do that for you, but in particular : what comes after « --- »
and before the patch itself is ignored by the tools, just an
informative message for people reading your email. What comes before
this « --- » is the commit message.
--
Matthieu
On Sun, 8 Jun 2008, Matthieu Moy wrote:
Boyd Lynn Gerber [off-list ref] writes:
quoted
This was from my own copy of the master archive. It is my proposal. I
thought you had to get an OK from this list before you do a push to the
main archive.
You won't do a push, the maintainer will apply the patch if it seems
OK.
Thanks, I understand better now.
quoted
What am I missing?
The format used to send patches. git format-patch and git send-email
would do that for you, but in particular : what comes after « --- »
and before the patch itself is ignored by the tools, just an
informative message for people reading your email. What comes before
this « --- » is the commit message.
I moved the message from above my commiter message because I was told to
add comments after the --- with the file being modified. The reasons for
the modifications. I used git format-patch -p -M -B origin to generate
this email. All I did was read the contents into the email I create for
posting. This was the advice I was given on IRC as the best method to
create/send the patch. When on IRC I was omitting the -p and was not
getting the .patch file. After reading the docs over and over I finally
noticed I was missing the -p. Once I added it I got the patch file and
then I emailed it to the list.
Thanks,
--
Boyd Gerber [off-list ref]
ZENEZ 1042 East Fort Union #135, Midvale Utah 84047
On Sun, 8 Jun 2008, Boyd Lynn Gerber wrote:
On Sun, 8 Jun 2008, Matthieu Moy wrote:
quoted
Boyd Lynn Gerber [off-list ref] writes:
quoted
This was from my own copy of the master archive. It is my proposal. I
thought you had to get an OK from this list before you do a push to the
main archive.
You won't do a push, the maintainer will apply the patch if it seems
OK.
Thanks, I understand better now.
By the way, if you want to send large series of patches, and you have
your git repository published somewhere (repo.or.cz, gitorious, github,
freedektop, kernel.org), sometimes pull request is used. As you
usually use git-format-patch (perhaps together with git-send-email)
when sending patches, you can use output of git-request-pull there.
Just FYI, you can safely ignore above.
quoted
quoted
What am I missing?
The format used to send patches. git format-patch and git send-email
would do that for you, but in particular : what comes after « --- »
and before the patch itself is ignored by the tools, just an
informative message for people reading your email. What comes before
this « --- » is the commit message.
I moved the message from above my commiter message because I was told to
add comments after the --- with the file being modified. The reasons for
the modifications. I used git format-patch -p -M -B origin to generate
this email. All I did was read the contents into the email I create for
posting. This was the advice I was given on IRC as the best method to
create/send the patch. When on IRC I was omitting the -p and was not
getting the .patch file. After reading the docs over and over I finally
noticed I was missing the -p. Once I added it I got the patch file and
then I emailed it to the list.
Strange. While in git-diff family of commands '-p' means generate
diff in patchset format:
-p Generate patch (see section on generating patches).
it has different meaning (oops) in git-format-patch:
-p Generate patches without diffstat.
(What is probably a bug in git-format-patch it doesn't add "---\n"
separator between commit message and patch itself).
Everything between "---\n" after commit message (usually ending in
Signed-off-by) and the diffstat and patch is a transient comment,
which won't get included in commit message, and wouldn't be anywhere
in the repository, neither in contents not in commits.
What you put there is information which shouldn't be in commit message,
like for example difference from previous version of patch, sometimes
explanation behind _why_ of this patch; you put there to which branch
this patch applies, if it is not 'master' (por example if it requires
material from 'next') or if given patch depends on earlier patch NOT
in the series.
IMVVVHO you should put verbatim copy of certificate of origin there,
but put the comment about which operating systems needs which defines,
or use which defines, and why either in commit message, in comment in
some file, or both.
HTH (Hope That Helps).
--
Jakub Narebski
Poland
On Sun, 8 Jun 2008, Jakub Narebski wrote:
On Sun, 8 Jun 2008, Boyd Lynn Gerber wrote:
quoted
On Sun, 8 Jun 2008, Matthieu Moy wrote:
quoted
Boyd Lynn Gerber [off-list ref] writes:
quoted
This was from my own copy of the master archive. It is my proposal. I
thought you had to get an OK from this list before you do a push to the
main archive.
You won't do a push, the maintainer will apply the patch if it seems
OK.
Thanks, I understand better now.
By the way, if you want to send large series of patches, and you have
your git repository published somewhere (repo.or.cz, gitorious, github,
freedektop, kernel.org), sometimes pull request is used. As you
usually use git-format-patch (perhaps together with git-send-email)
when sending patches, you can use output of git-request-pull there.
Just FYI, you can safely ignore above.
I have setup a repo on www.zenez.com.
I just did a git clone give://www.zenez.com/git git.
I am trying to get various communities to use git. So I want all there
changes to go to my master repo. I am trying to get those that still
support/work on SCO OS's to embrase the Open Source Software (OSS)
concepts and give back to the OSS community inspite of the SCO Group and
what they are doing. I am a firm believer of OSS Concepts. I still have
to support many SCO Systems. My clients applicatios only run on them.
But I want as much as I can to promote the OSS Concepts and have them
become a major part of the business I support.
Because of all the anti SCO I want them to have a safe place to use and
provide good services for them. Saddly, I do this because of my own
experience with retrobuction from fanatics. I have had over 650 GB over
written with "DIE SCO" I was away for a week and when I came back I had
had a break-in on one system and that was the result. I have had DOS
attacks and many others. So I am trying to be a bridge between the to
communities and other communites to promote the true spirt of Open Source.
--
Boyd Gerber [off-list ref]
ZENEZ 1042 East Fort Union #135, Midvale Utah 84047
On Sun, 8 Jun 2008, Boyd Lynn Gerber wrote:
I have setup a repo on www.zenez.com.
I just did a git clone give://www.zenez.com/git git.
Sorry type-o should have been
git clone git://www.zenez.com/git git
--
Boyd Gerber [off-list ref]
ZENEZ 1042 East Fort Union #135, Midvale Utah 84047