[PATCH] Documentation: git-cherry uses git-patch-id

Subsystems: documentation, the rest

DORMANTno replies

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

[PATCH] Documentation: git-cherry uses git-patch-id

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:39

"Geoffrey Irving" [off-list ref] writes:
On Wed, May 28, 2008 at 1:46 PM, Junio C Hamano [off-list ref] wrote:
quoted
Thanks.

In manual pages, "SEE ALSO" section is a more appropriate place to do this
kind of thing.
Here's an improved patch.
Thanks, I'll do this instead...

-- >8 --
Geoffrey Irving noticed that git-cherry talks about comparing commits without
hinting how they are compared.

Signed-off-by: Junio C Hamano <redacted>
---
 Documentation/git-cherry.txt |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/Documentation/git-cherry.txt b/Documentation/git-cherry.txt
index b0468aa..d8e0a5b 100644
--- a/Documentation/git-cherry.txt
+++ b/Documentation/git-cherry.txt
@@ -13,6 +13,8 @@ DESCRIPTION
 -----------
 The changeset (or "diff") of each commit between the fork-point and <head>
 is compared against each commit between the fork-point and <upstream>.
+The commits are compared with their 'patch id', obtained from linkgit:git-patch-id[1]
+program.
 
 Every commit that doesn't exist in the <upstream> branch
 has its id (sha1) reported, prefixed by a symbol.  The ones that have
@@ -56,6 +58,10 @@ OPTIONS
 <limit>::
 	Do not report commits up to (and including) limit.
 
+SEE ALSO
+--------
+linkgit:git-patch-id[1]
+
 Author
 ------
 Written by Junio C Hamano <junkio@cox.net>
-- 
1.5.6.rc0.43.g823ea

Re: [PATCH] Documentation: git-cherry uses git-patch-id

From: Geoffrey Irving <hidden>
Date: 2016-06-15 22:44:39

On Wed, May 28, 2008 at 5:04 PM, Junio C Hamano [off-list ref] wrote:
"Geoffrey Irving" [off-list ref] writes:
quoted
On Wed, May 28, 2008 at 1:46 PM, Junio C Hamano [off-list ref] wrote:
quoted
Thanks.

In manual pages, "SEE ALSO" section is a more appropriate place to do this
kind of thing.
Here's an improved patch.
Thanks, I'll do this instead...
Thanks!

Incidentally, my original source of confusion was not understanding
the order of arguments of git-cherry.  Everything works fine once I
use the correct order.

Geoffrey
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help