Re: [PATCH resend] perl/Makefile.PL: teach makefiles about possible old Error.pm files

Chris Frey [off-list ref] writes:

On Thu, May 22, 2008 at 12:46:12PM +0100, Johannes Schindelin wrote:

quoted

I do not see how it is _Git_ that breaks itself by repeated installs.  It 
detects that there is an Error.pm.  Fine.  You _remove_ it while 
installing Git.  Not fine.  Not Git's error.

I guess I take the view that anything _installed_ by git is a part of git.
If git installs Error.pm, it can't expect the user to keep it around
if he uninstalls that version of git.

True, as we do not give "uninstall" target.  That's what distros are for.

On Thu, May 22, 2008 at 10:26:14AM -0700, Junio C Hamano wrote:

quoted

I guess I take the view that anything _installed_ by git is a part of git.
If git installs Error.pm, it can't expect the user to keep it around
if he uninstalls that version of git.

True, as we do not give "uninstall" target.  That's what distros are for.

I don't see how you can say "true" to what I said and keep git doing the
exact opposite. :-)

Anyway, there are other ways to fix this than INSTALLED_BY and I'm not
married to that idea, but if this isn't seen as a problem in the first
place, there's little use.

Would you accept a patch to the INSTALL file explaining this dependency?

Thanks,
- Chris

On Thu, May 22, 2008 at 7:26 PM, Junio C Hamano [off-list ref] wrote:

True, as we do not give "uninstall" target.  That's what distros are for.

Why is this though? I think there are a few distro's out there (call
them the hardcore/diehard ones) that don't use packages, instead they
rely on keeping the install dir around so that you can 'make
uninstall' later.

-- 
Cheers,

Sverre Rabbelier

Signed-off-by: Chris Frey <redacted>
---
 INSTALL |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/INSTALL b/INSTALL
index d9b425f..c5cafc4 100644
--- a/INSTALL
+++ b/INSTALL

@@ -86,6 +86,13 @@ Issues of note:
 	- "cpio" is used by git-clone when doing a local (possibly
 	  hardlinked) clone.
 
+	- "Error.pm" version >= 0.15009 is required by perl scripts.
+
+	  If you don't have a fresh enough Error.pm, git will install its
+	  own.  If you already have git installed, it will not install
+	  another Error.pm.  If this causes problems for you, uninstall
+	  git before compiling, or just install your distro's Error.pm.
+
  - Some platform specific issues are dealt with Makefile rules,
    but depending on your specific installation, you may not
    have all the libraries/tools needed, or you may have

-- 
1.5.4.4