Re: [PATCH 2/2] Documentation: bisect: add a few "git bisect run" examples

4 messages, 4 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 2/2] Documentation: bisect: add a few "git bisect run" examples

From: Matthieu Moy <hidden>
Date: 2016-06-15 22:44:34

Junio C Hamano [off-list ref] writes:
quoted
+------------
+echo "#"\!"/bin/sh" > ~/test.sh
+echo "make install || exit 125" >> ~/test.sh
+echo "~/check_test_case.sh" >> ~/test.sh
+chmod u+x ~/test.sh
s/install//; let's not set a bad example of installing first and then
testing.
Perhaps also s/~/./g, since it's not a good idea to put temporary
files in $HOME IMHO.

Also, using simple quotes instead of double would simplify the
"#"\!"/bin/sh".

-- 
Matthieu

Re: [PATCH 2/2] Documentation: bisect: add a few "git bisect run" examples

From: Miklos Vajna <hidden>
Date: 2016-06-15 22:44:34

On Wed, May 07, 2008 at 08:29:03AM +0200, Matthieu Moy [off-list ref] wrote:
Perhaps also s/~/./g, since it's not a good idea to put temporary
files in $HOME IMHO.
the point is to have it outside the repo. at least i regularly have 'git
clean -f -x -d' in such a script if i don't trust the upstream build
system. ;)

Re: [PATCH 2/2] Documentation: bisect: add a few "git bisect run" examples

From: Jon Loeliger <hidden>
Date: 2016-06-15 22:44:34

On Wed, 2008-05-07 at 08:29 +0200, Matthieu Moy wrote:
Junio C Hamano [off-list ref] writes:
quoted
quoted
+------------
+echo "#"\!"/bin/sh" > ~/test.sh
+echo "make install || exit 125" >> ~/test.sh
+echo "~/check_test_case.sh" >> ~/test.sh
+chmod u+x ~/test.sh
s/install//; let's not set a bad example of installing first and then
testing.
Perhaps also s/~/./g, since it's not a good idea to put temporary
files in $HOME IMHO.

Also, using simple quotes instead of double would simplify the
"#"\!"/bin/sh".
Hmm.  I would have just done "$ cat ~/test.sh" and
then shown the file listing directly.

jdl

Re: [PATCH 2/2] Documentation: bisect: add a few "git bisect run" examples

From: Christian Couder <hidden>
Date: 2016-06-15 22:44:35

Le mercredi 7 mai 2008, Miklos Vajna a écrit :
On Wed, May 07, 2008 at 08:29:03AM +0200, Matthieu Moy 
[off-list ref] wrote:
quoted
Perhaps also s/~/./g, since it's not a good idea to put temporary
files in $HOME IMHO.
the point is to have it outside the repo. 
Yes. Especially, if the test case is a new one, the scripts that are used 
must not have been checked in. Otherwise when bisect will checkout older 
versions, the scripts will be removed.
at least i regularly have 'git 
clean -f -x -d' in such a script if i don't trust the upstream build
system. ;)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help